refactor: add try except logic for JSON parsing and response handling #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Govind Hede <govindhede1408@gmail.com>
sfc-gh-twhite
force-pushed
the
add-try-except
branch
from
1b73e56 to
3a917e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GovindHede - I was working through #65 but ultimately had too much to comb through, and the tests are failing.
FAILED tests/test_quickstart.py::test_gateway_agent[market_cap] - agent_gateway.gateway.gateway.AgentGatewayError: Unable to retrieve response. Please check each of your Cortex tools and ensure all connections are v...
FAILED tests/test_quickstart.py::test_gateway_agent[product_revenue] - agent_gateway.gateway.gateway.AgentGatewayError: Unable to retrieve response. Please check each of your Cortex tools and ensure all connections are v...
This PR opens up the changes only for what we wanted to capture here. I added you as a co-author for the commit, so you'll still have the contribution. Thanks for helping with this!
@sfc-gh-alherrera: These tests are still failing, I'll do some deeper digging in a little bit, just wanted to get this opened.