fix: refactoring parser to address long response bugs and debug log cleanups#79
Merged
sfc-gh-alherrera merged 4 commits intomainfrom Dec 6, 2024
Merged
fix: refactoring parser to address long response bugs and debug log cleanups#79sfc-gh-alherrera merged 4 commits intomainfrom
sfc-gh-alherrera merged 4 commits intomainfrom
Conversation
Co-authored-by: Tyler White <tyler.white@snowflake.com>
| if "choices" not in response_text: | ||
| raise AgentGatewayError( | ||
| message=f"Failed Cortex LLM Request. Missing choices in response. See details:{response_text}" | ||
| message=f"Invalid Cortex LLM Response. See details:{response_text}" |
Collaborator
There was a problem hiding this comment.
What are the possibilities here?
Would it only hit this block in the case of Analyst not returning either the text response with suggestions or an SQL expression?
Collaborator
Author
There was a problem hiding this comment.
this is for the complete calls, not analyst. there can be cases where complete is not configured properly (invalid model provided by end user..etc) or the response comes back empty
sfc-gh-twhite
approved these changes
Dec 6, 2024
Collaborator
sfc-gh-twhite
left a comment
sfc-gh-twhite
left a comment
There was a problem hiding this comment.
LGTM! Small comment regarding clarity (maybe we can add some comments about why we're inside that "if choices not in" section) - but not a blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g logs cleanup