-
Notifications
You must be signed in to change notification settings - Fork 237
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #265 from Snowflake-Labs/dev
feat: tests, docs, linting, remove pandas dep
- Loading branch information
Showing
58 changed files
with
2,687 additions
and
1,128 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,88 @@ | ||
| name: dev-pytest | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - dev | ||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| pull_request: | ||
| types: | ||
| - labeled | ||
| branches: | ||
| - dev | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| scenario-name: [ 'basics_demo', 'citibike_demo', 'citibike_demo_jinja'] | ||
| os: ["ubuntu-latest"] | ||
| python-version: ["3.11"] | ||
| runs-on: ${{ matrix.os }} | ||
| if: ${{ github.event.label.name == 'ci-run-tests' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' }} | ||
|
|
||
| env: | ||
| SNOWFLAKE_PASSWORD: ${{ secrets.SCHEMACHANGE_SNOWFLAKE_PASSWORD }} | ||
| SNOWFLAKE_USER: ${{ secrets.SCHEMACHANGE_SNOWFLAKE_USER }} | ||
| SNOWFLAKE_ACCOUNT: ${{ secrets.SCHEMACHANGE_SNOWFLAKE_ACCOUNT }} | ||
| SNOWFLAKE_DATABASE: SCHEMACHANGE_DEMO | ||
| SNOWFLAKE_WAREHOUSE: SCHEMACHANGE_DEMO_WH | ||
| SNOWFLAKE_ROLE: '"SCHEMACHANGE_DEMO-DEPLOY"' | ||
| MY_TARGET_SCHEMA: ${{ matrix.scenario-name }}_${{ github.run_number }}_${{ strategy.job-index }} | ||
| SCENARIO_NAME: ${{ matrix.scenario-name }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Set up Python 3.11 | ||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.11" | ||
| - name: Update pip | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python-version: ${{ matrix.python-version }} | ||
| # The next few steps (Install dependencies, Lint with Flake8, Test with Pytest) will install Python dependencies, | ||
| # run tests and lint with a variety of Python versions | ||
| # For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m pip install flake8 pytest | ||
| python -m pip install -e .[dev] | ||
| if [ -f requirements.txt ]; then pip install -r requirements.txt; fi | ||
| - name: Lint with flake8 | ||
| run: | | ||
| # stop the build if there are Python syntax errors or undefined names | ||
| flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics | ||
| # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide | ||
| flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics | ||
| - name: Test with pytest | ||
| id: pytest | ||
| run: | | ||
| pytest | ||
| # Testing Schemachange demo projects | ||
| - name: Test Schemachange on ${{ matrix.os }} targeting ${{ env.SNOWFLAKE_DATABASE }}.${{ env.MY_TARGET_SCHEMA }} schema | ||
| run: | | ||
| echo "::group::Setting up ${MY_TARGET_SCHEMA}" | ||
| schemachange deploy --config-folder ./demo/setup/${SCENARIO_NAME} | ||
| echo "::endgroup::" | ||
| echo "::group::Testing Rendering to ${MY_TARGET_SCHEMA}" | ||
| schemachange render --config-folder ./demo/${SCENARIO_NAME} ./demo/${SCENARIO_NAME}/A__render.sql | ||
| schemachange render --config-folder ./demo/${SCENARIO_NAME} ./demo/${SCENARIO_NAME}/R__render.sql | ||
| schemachange render --config-folder ./demo/${SCENARIO_NAME} ./demo/${SCENARIO_NAME}/V1.0.0__render.sql | ||
| echo "::endgroup::" | ||
| echo "::group::Testing Deployment using ${MY_TARGET_SCHEMA}" | ||
| set +e | ||
| schemachange deploy --config-folder ./demo/${SCENARIO_NAME} | ||
| RESULT=$? | ||
| if [ $RESULT -eq 0 ]; then | ||
| echo "Deployment Completed!" | ||
| else | ||
| echo "Deployment Failed. Proceeding to Teardown." | ||
| fi | ||
| echo "::endgroup::" | ||
| set -e | ||
| echo "::group::Tearing down up ${MY_TARGET_SCHEMA}" | ||
| schemachange deploy --config-folder ./demo/teardown/${SCENARIO_NAME} | ||
| echo "::endgroup::" | ||
| if [ $RESULT -ne 0 ]; then | ||
| exit 1 | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| name: master-pytest | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| pull_request: | ||
| types: | ||
| - labeled | ||
| branches: | ||
| - main | ||
|
|
||
| push: | ||
| tags: | ||
| - "v*" # Push events to matching v*, i.e. v3.6.2, v4.0.0 | ||
|
|
||
|
|
||
| jobs: | ||
| build: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| scenario-name: [ 'basics_demo', 'citibike_demo', 'citibike_demo_jinja'] | ||
| os: ["ubuntu-latest", "macos-latest", "windows-latest"] | ||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | ||
| runs-on: ${{ matrix.os }} | ||
| if: ${{ github.event.label.name == 'ci-run-tests' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' }} | ||
| env: | ||
| SNOWFLAKE_PASSWORD: ${{ secrets.SCHEMACHANGE_SNOWFLAKE_PASSWORD }} | ||
| SNOWFLAKE_USER: ${{ secrets.SCHEMACHANGE_SNOWFLAKE_USER }} | ||
| SNOWFLAKE_ACCOUNT: ${{ secrets.SCHEMACHANGE_SNOWFLAKE_ACCOUNT }} | ||
| SNOWFLAKE_DATABASE: SCHEMACHANGE_DEMO | ||
| SNOWFLAKE_WAREHOUSE: SCHEMACHANGE_DEMO_WH | ||
| SNOWFLAKE_ROLE: '"SCHEMACHANGE_DEMO-DEPLOY"' | ||
| MY_TARGET_SCHEMA: ${{ matrix.scenario-name }}_${{ github.run_number }}_${{ strategy.job-index }} | ||
| SCENARIO_NAME: ${{ matrix.scenario-name }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| # The next few steps (Install dependencies, Lint with Flake8, Test with Pytest) will install Python dependencies, | ||
| # run tests and lint with a variety of Python versions | ||
| # For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| python -m pip install flake8 pytest | ||
| python -m pip install -e .[dev] | ||
| if [ -f requirements.txt ]; then pip install -r requirements.txt; fi | ||
| - name: Lint with flake8 | ||
| run: | | ||
| # stop the build if there are Python syntax errors or undefined names | ||
| flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics | ||
| # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide | ||
| flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics | ||
| - name: Test with pytest | ||
| id: pytest | ||
| run: | | ||
| pytest | ||
| # Testing Schemachange demo projects | ||
| - name: Test Schemachange on ${{ matrix.os }} targeting ${{ env.SNOWFLAKE_DATABASE }}.${{ env.MY_TARGET_SCHEMA }} schema | ||
| run: | | ||
| echo "::group::Setting up ${MY_TARGET_SCHEMA}" | ||
| schemachange deploy --config-folder ./demo/setup/${SCENARIO_NAME} | ||
| echo "::endgroup::" | ||
| echo "::group::Testing Rendering to ${MY_TARGET_SCHEMA}" | ||
| schemachange render --config-folder ./demo/${SCENARIO_NAME} ./demo/${SCENARIO_NAME}/A__render.sql | ||
| schemachange render --config-folder ./demo/${SCENARIO_NAME} ./demo/${SCENARIO_NAME}/R__render.sql | ||
| schemachange render --config-folder ./demo/${SCENARIO_NAME} ./demo/${SCENARIO_NAME}/V1.0.0__render.sql | ||
| echo "::endgroup::" | ||
| echo "::group::Testing Deployment using ${MY_TARGET_SCHEMA}" | ||
| set +e | ||
| schemachange deploy --config-folder ./demo/${SCENARIO_NAME} | ||
| RESULT=$? | ||
| if [ $RESULT -eq 0 ]; then | ||
| echo "Deployment Completed!" | ||
| else | ||
| echo "Deployment Failed. Proceeding to Teardown." | ||
| fi | ||
| echo "::endgroup::" | ||
| set -e | ||
| echo "::group::Tearing down up ${MY_TARGET_SCHEMA}" | ||
| schemachange deploy --config-folder ./demo/teardown/${SCENARIO_NAME} | ||
| echo "::endgroup::" | ||
| if [ $RESULT -ne 0 ]; then | ||
| exit 1 | ||
| fi |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,43 @@ | ||
| # See https://pre-commit.com for more information | ||
| # See https://pre-commit.com/hooks.html for more hooks | ||
| repos: | ||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v3.2.0 | ||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v4.5.0 | ||
| hooks: | ||
| - id: trailing-whitespace | ||
| - id: end-of-file-fixer | ||
| - repo: https://github.com/asottile/setup-cfg-fmt | ||
| - id: trailing-whitespace | ||
| - id: end-of-file-fixer | ||
| - id: check-ast | ||
| - id: check-case-conflict | ||
| - id: check-docstring-first | ||
| - id: check-merge-conflict | ||
| - id: check-toml | ||
| - id: check-yaml | ||
| - id: name-tests-test | ||
| - repo: https://github.com/asottile/setup-cfg-fmt | ||
| rev: v2.4.0 | ||
| hooks: | ||
| - id: setup-cfg-fmt | ||
| - id: setup-cfg-fmt | ||
| - repo: https://github.com/asottile/pyupgrade | ||
| rev: v3.15.2 | ||
| hooks: | ||
| - id: pyupgrade | ||
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| # Ruff version. | ||
| rev: v0.3.4 | ||
| hooks: | ||
| # Run the linter. | ||
| - id: ruff | ||
| args: [ --fix ] | ||
| # Run the formatter. | ||
| - id: ruff-format | ||
| - repo: git@github.com:GitGuardian/ggshield.git | ||
| rev: v1.28.0 | ||
| hooks: | ||
| - id: ggshield | ||
| language_version: python3 | ||
| stages: [commit] | ||
| - repo: https://github.com/PyCQA/flake8 | ||
| rev: '6.0.0' | ||
| hooks: | ||
| - id: flake8 | ||
| args: [ '--max-line-length=88', '--extend-ignore=E203,E501,W503,E266', '--exclude=.venv' ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.