Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes #300

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Changes #300

merged 9 commits into from
Oct 30, 2024

Conversation

sfc-gh-tmathew
Copy link
Collaborator

  • Removed 3.8 from github actions and added 3.12
  • Updated contributing guide and docs to make it cohesive.

@sfc-gh-tmathew
Changes
1a7ed11 
- Removed 3.8 from github actions and added 3.12
- Updated contributing guide and docs to make it cohesive.
sfc-gh-twhite
sfc-gh-twhite approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-twhite sfc-gh-twhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! A few small nitpicks, but nothing blocking.

sfc-gh-tmathew and others added 7 commits October 29, 2024 15:53
@sfc-gh-tmathew @sfc-gh-twhite
Update .github/CONTRIBUTING.md
8004ed9 
Accepting review comments.

Co-authored-by: Tyler White <tyler.white@snowflake.com>
@sfc-gh-tmathew @sfc-gh-twhite
Update demo/README.MD
402cb2b 
Accepting Review comment

Co-authored-by: Tyler White <tyler.white@snowflake.com>
@sfc-gh-tmathew @sfc-gh-twhite
Update demo/README.MD
73cbe88 
accepted

Co-authored-by: Tyler White <tyler.white@snowflake.com>
@sfc-gh-tmathew @sfc-gh-twhite
Update demo/README.MD
6314ce4 
Accepted

Co-authored-by: Tyler White <tyler.white@snowflake.com>
@sfc-gh-tmathew @sfc-gh-twhite
Update demo/README.MD
bf08a2a 
Accepted

Co-authored-by: Tyler White <tyler.white@snowflake.com>
@sfc-gh-tmathew
Implementing review changes
2c553e8
@sfc-gh-tmathew
Implementing review comments
11bdee7
sfc-gh-jhansen
sfc-gh-jhansen approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-jhansen sfc-gh-jhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sfc-gh-tmathew sfc-gh-tmathew merged commit 871d7c7 into master Oct 30, 2024
4 checks passed
@sfc-gh-tmathew sfc-gh-tmathew deleted the update_contributing_guidelines branch October 30, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jhansen sfc-gh-jhansen sfc-gh-jhansen approved these changes

@sfc-gh-twhite sfc-gh-twhite sfc-gh-twhite approved these changes

@jeremiahhansen jeremiahhansen Awaiting requested review from jeremiahhansen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-tmathew @sfc-gh-jhansen @sfc-gh-twhite