feat: Tasks v1 readiness - SDK part #2193
Triggered via pull request
September 20, 2024 14:06
sfc-gh-jcieslak
Status
Success
Total duration
1m 22s
Artifacts
–
reviewdog-golanglint-ci.yml
on: pull_request
reviewdog
1m 11s
Annotations
5 errors and 1 warning
|
reviewdog:
pkg/acceptance/bettertestspoc/assert/objectparametersassert/gen/object_parameters_def.go#L254
[golangci] reported by reviewdog 🐶
commentFormatting: put a space between `//` and comment text (gocritic)
Raw Output:
pkg/acceptance/bettertestspoc/assert/objectparametersassert/gen/object_parameters_def.go:254:4: commentFormatting: put a space between `//` and comment text (gocritic)
//{ParameterName: string(sdk.UserParameterUnsupportedUserTaskMinimumTriggerIntervalInSeconds), ParameterType: "int", DefaultValue: "30", DefaultLevel: "sdk.ParameterTypeSnowflakeDefault"},
^
|
|
reviewdog:
pkg/sdk/testint/tasks_gen_integration_test.go#L508
[golangci] reported by reviewdog 🐶
commentFormatting: put a space between `//` and comment text (gocritic)
Raw Output:
pkg/sdk/testint/tasks_gen_integration_test.go:508:3: commentFormatting: put a space between `//` and comment text (gocritic)
//assertions.AssertThat(t, objectparametersassert.TaskParameters(t, task.ID()).
^
|
|
reviewdog:
pkg/sdk/testint/tasks_gen_integration_test.go#L548
[golangci] reported by reviewdog 🐶
commentFormatting: put a space between `//` and comment text (gocritic)
Raw Output:
pkg/sdk/testint/tasks_gen_integration_test.go:548:3: commentFormatting: put a space between `//` and comment text (gocritic)
//assertions.AssertThat(t, objectparametersassert.TaskParameters(t, task.ID()).
^
|
|
reviewdog:
pkg/sdk/testint/tasks_gen_integration_test.go#L4
[golangci] reported by reviewdog 🐶
File is not `gofumpt`-ed (gofumpt)
Raw Output:
pkg/sdk/testint/tasks_gen_integration_test.go:4: File is not `gofumpt`-ed (gofumpt)
"fmt"
|
|
reviewdog:
pkg/sdk/testint/tasks_gen_integration_test.go#L5
[golangci] reported by reviewdog 🐶
File is not `goimports`-ed (goimports)
Raw Output:
pkg/sdk/testint/tasks_gen_integration_test.go:5: File is not `goimports`-ed (goimports)
"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/bettertestspoc/assert/objectparametersassert"
"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/helpers/random"
|
|
reviewdog
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|