Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix workflows #2206

Merged
merged 5 commits into from
Nov 22, 2023
Merged

fix: Fix workflows #2206

merged 5 commits into from
Nov 22, 2023

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Nov 22, 2023 •
edited
Loading

Fix errors introduced by #2150.

Changes

  • Merge test and test-acceptance back
  • add missing skips in tests (reason: behavior change after introducing SNOWFLAKE_CONFIG_FILE)
  • add filtering to test-acceptance
  • introduce sweepers back
  • introduce comments back

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review November 22, 2023 11:28
@github-actions GitHub Actions
Copy link

Integration tests failure for 37b776c95d1c0118f77cfdfc07e6c05d842e7db3

@github-actions GitHub Actions
Copy link

Integration tests failure for 45f6601668ba19b8a54514ce8c1c4f9c3e1341e0

@github-actions GitHub Actions
Copy link

Integration tests success for aec499e1a742bc55945b05715871dac66dafb149

@sfc-gh-asawicki sfc-gh-asawicki merged commit 6d7f833 into main Nov 22, 2023
9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the fix-workflows branch November 22, 2023 13:11
@snowflake-release-please snowflake-release-please bot mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-asawicki @sfc-gh-jcieslak