Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling up and down lambdas #103

Merged
merged 10 commits into from
Oct 11, 2024
Merged

Scaling up and down lambdas #103

merged 10 commits into from
Oct 11, 2024

Conversation

cyramic
Copy link
Contributor

@cyramic cyramic commented Aug 20, 2024

  • Adds lambda functions to scale ECS services up and down based on a schedule
  • Adds basic unit tests
  • Does NOT add auto-deployment (CD) so code will manually need to be put into the s3 bucket for now.

Copy link
Member

@tab1tha tab1tha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic and syntax is consistent so looks good to me.
My understanding of cloudformation is in it's early stages. So I am not yet able to have in-depth opinions about the implementation.

…ded environment parameter for staging to allow force-redeploys ignoring cache
Merge branch 'main' into feat/lambda-scaling
mock_update_service = Mock(return_value={"some": "response"})

# Invoke the Lambda function with a sample event (optional)
event = {"key": "value"} # You can provide a sample event here if needed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the pipelinestatus default to "false" here? Just curious how in the update_serice.assert_has_calls the desiredCount is set to 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! I hadn't updated the tests. Will fix now.

@cyramic cyramic merged commit 547d018 into main Oct 11, 2024
1 check passed
@cyramic cyramic deleted the feat/lambda-scaling branch October 11, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants