-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaling up and down lambdas #103
Conversation
cyramic
commented
Aug 20, 2024
- Adds lambda functions to scale ECS services up and down based on a schedule
- Adds basic unit tests
- Does NOT add auto-deployment (CD) so code will manually need to be put into the s3 bucket for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic and syntax is consistent so looks good to me.
My understanding of cloudformation is in it's early stages. So I am not yet able to have in-depth opinions about the implementation.
infrastructure/environments/cloudformation/full/common/scaling.yaml
Outdated
Show resolved
Hide resolved
…ded environment parameter for staging to allow force-redeploys ignoring cache
Merge branch 'main' into feat/lambda-scaling
mock_update_service = Mock(return_value={"some": "response"}) | ||
|
||
# Invoke the Lambda function with a sample event (optional) | ||
event = {"key": "value"} # You can provide a sample event here if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the pipelinestatus
default to "false" here? Just curious how in the update_serice.assert_has_calls
the desiredCount is set to 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point! I hadn't updated the tests. Will fix now.
infrastructure/environments/cloudformation/full/common/lambda/ecs_scale/README.md
Outdated
Show resolved
Hide resolved
…ecs_scale/README.md Co-authored-by: Christina Moore <30839329+christina-moore@users.noreply.github.com>