feat(contributions): ajouter des infographies #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # targets/frontend/src/components/forms/EditionField/MenuSpecial.tsx
tokenbureau
bot
temporarily deployed
to
review-linked-feat-infographic-3qupee
tokenbureau
bot
temporarily deployed
to
review-linked-feat-infographic-3qupee
m-maillot
force-pushed
the
linked/feat/infographic
branch
from
b26aee5 to
3efe729
Compare
tokenbureau
bot
temporarily deployed
to
review-linked-feat-infographic-3qupee
m-maillot
force-pushed
the
linked/feat/infographic
branch
from
3efe729 to
07255a1
Compare
tokenbureau
bot
temporarily deployed
to
review-linked-feat-infographic-3qupee
m-maillot
requested review from
maxgfr,
Viczei and
carolineBda
and removed request for
Viczei
# Conflicts: # targets/frontend/src/components/forms/EditionField/MenuSpecial.tsx # Conflicts: # targets/frontend/src/components/forms/EditionField/Editor.tsx # targets/frontend/src/components/forms/EditionField/extensions/Infographic.ts
m-maillot
force-pushed
the
linked/feat/infographic
branch
from
07255a1 to
b42b05c
Compare
|
|
🎉 Deployment for commit b42b05c : Docker images
|
maxgfr
approved these changes
Feb 10, 2025
Comment on lines
+28
to
+33
| ARG NEXT_PUBLIC_BUCKET_PUBLIC_ENDPOINT | ||
| ENV NEXT_PUBLIC_BUCKET_PUBLIC_ENDPOINT=$NEXT_PUBLIC_BUCKET_PUBLIC_ENDPOINT | ||
| ARG NEXT_PUBLIC_BUCKET_DEFAULT_FOLDER | ||
| ENV NEXT_PUBLIC_BUCKET_DEFAULT_FOLDER=$NEXT_PUBLIC_BUCKET_DEFAULT_FOLDER | ||
| ARG NEXT_PUBLIC_BUCKET_DRAFT_FOLDER | ||
| ENV NEXT_PUBLIC_BUCKET_DRAFT_FOLDER=$NEXT_PUBLIC_BUCKET_DRAFT_FOLDER |
There was a problem hiding this comment.
yes, ça me semble bon comme ça !
Comment on lines
+22
to
+30
| import { | ||
| Button, | ||
| DialogActions, | ||
| DialogContentText, | ||
| TextField, | ||
| } from "@mui/material"; | ||
| import DialogTitle from "@mui/material/DialogTitle"; | ||
| import Dialog from "@mui/material/Dialog"; | ||
| import DialogContent from "@mui/material/DialogContent"; |
There was a problem hiding this comment.
ça nous sauve tellement la vie cette lib :p
Comment on lines
43
to
+46
|
|
||
| type ModeCreation = { | ||
| mode: 0; | ||
| }; |
There was a problem hiding this comment.
on peut laisser les types ici, car on ne les partage pas, c'est bien ça ?
Comment on lines
+105
to
+107
| addCommands() { | ||
| return { | ||
| setInfographic: |
There was a problem hiding this comment.
bon à savoir, si on veut l'améliorer dans le futur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.