Skip to content

test: include Path-B fixtures in Go/Rust verification; update audit doc #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdheller merged 1 commit into from
Feb 8, 2026
Merged

test: include Path-B fixtures in Go/Rust verification; update audit doc #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/audit_tritrpc_v1_parity.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and the corrective actions taken.
| A5 | **Medium** | Spec/docs claimed MAC fallback, rolling nonces, and AUX structures were supported across ports. | Spec/docs now reflect current port behavior (`spec/README-full-spec.md` L7-L23; `docs/THEORY.md` L70-L94). | **Fixed** |
| A6 | **Low** | README referenced CI/repack-check jobs that did not exist. | Added `Makefile` + CI workflow and updated README (`Makefile` L1-L20; `.github/workflows/ci.yml` L1-L27; `README.md` L106-L120). | **Fixed** |
| A7 | **Low** | Tag comparisons used direct equality; constant-time compare was missing. | Constant-time comparisons now used in Go/Rust fixture checks (`go/tritrpcv1/fixtures_test.go` L117-L122; `rust/tritrpc_v1/tests/fixtures.rs` L123-L125). | **Fixed** |
| A8 | **Medium** | Go/Rust fixture verification omitted Path‑B fixtures, leaving repack determinism unchecked for ternary payload frames. | Path‑B fixtures are now included in Go/Rust fixture test sets (`go/tritrpcv1/fixtures_test.go` L73-L77; `rust/tritrpc_v1/tests/fixtures.rs` L60-L79). | **Fixed** |

## Scope checklist coverage

Expand Down
1 change: 1 addition & 0 deletions go/tritrpcv1/fixtures_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ func TestFixturesAEADAndPayloads(t *testing.T) {
{"fixtures/vectors_hex_stream_avrochunk.txt", "fixtures/vectors_hex_stream_avrochunk.txt.nonces"},
{"fixtures/vectors_hex_unary_rich.txt", "fixtures/vectors_hex_unary_rich.txt.nonces"},
{"fixtures/vectors_hex_stream_avronested.txt", "fixtures/vectors_hex_stream_avronested.txt.nonces"},
{"fixtures/vectors_hex_pathB.txt", "fixtures/vectors_hex_pathB.txt.nonces"},
}
key := [32]byte{}
for _, s := range sets {
Expand Down
4 changes: 4 additions & 0 deletions rust/tritrpc_v1/tests/fixtures.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ fn verify_all_frames_and_payloads() {
"fixtures/vectors_hex_stream_avronested.txt",
"fixtures/vectors_hex_stream_avronested.txt.nonces",
),
(
"fixtures/vectors_hex_pathB.txt",
"fixtures/vectors_hex_pathB.txt.nonces",
),
];
let key = [0u8; 32];
for (fx, nx) in sets {
Expand Down
Loading