Fix connectivity android #568
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c/common
wcoder
reviewed
Nov 20, 2024
| /// <param name="disposing"><c>true</c> to dispose managed state.</param> | ||
| /// <seealso cref="Dispose"/> | ||
| /// <seealso cref="T:System.IDisposable"/> | ||
| protected virtual void Dispose(bool disposing) |
There was a problem hiding this comment.
Please add additional public method:
public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
}to be able to remove observer from outside
| { | ||
| Connectivity.ConnectivityChanged -= CurrentConnectivityChanged; | ||
| Connectivity.ConnectivityChanged += CurrentConnectivityChanged; | ||
| CurrentConnectivityChanged(this, new ConnectivityChangedEventArgs(Connectivity.NetworkAccess, Connectivity.ConnectionProfiles)); |
There was a problem hiding this comment.
Is it really necessary to manually trigger an event only on Start at this place?
| /// </param> | ||
| public DroidConnectivityService(IConnectivity connectivity) : base(connectivity) | ||
| { | ||
| _startAction = new WeakAction(OnAppStart); |
There was a problem hiding this comment.
Do you need Lifecycle.Event.ON_CREATE or ON_RESUME also?
wcoder
reviewed
Nov 20, 2024
| @@ -18,4 +18,8 @@ | |||
| <ProjectReference Include="..\Softeq.XToolkit.Common\Softeq.XToolkit.Common.csproj" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Xamarin.AndroidX.Lifecycle.Process" Version="2.6.2.1" /> | |||
There was a problem hiding this comment.
The main reason for Common projects is 'no 3rd-party dependencies'
wcoder
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
PR Checklist