[MTM-54517]allow registration of custom filters #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaczynskid-sag
requested review from
karol-c8y,
jkot-c8y,
AleksanderFiszSoftwareag and
kaczynskid-sag
java-client/src/main/java/com/cumulocity/sdk/client/RestConnector.java
Outdated
Show resolved
Hide resolved
java-client/src/main/java/com/cumulocity/sdk/client/RestConnector.java
Outdated
Show resolved
Hide resolved
java-client/src/main/java/com/cumulocity/sdk/client/RestConnector.java
Outdated
Show resolved
Hide resolved
| @@ -455,6 +456,16 @@ public static Client createClient(PlatformParameters platformParameters) { | |||
| return client; | |||
| } | |||
|
|
|||
| private static void registerExternalFilters(PlatformParameters platformParameters,ClientConfig config) { | |||
| if (platformParameters.customFilterSet != null) { | |||
There was a problem hiding this comment.
How can it ever be null?
There was a problem hiding this comment.
Agree. Remove this check now. Please have a look.
java-client/src/main/java/com/cumulocity/sdk/client/PlatformParameters.java
Outdated
Show resolved
Hide resolved
jkot-c8y
reviewed
Feb 15, 2024
karol-c8y
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a related change to
DAST scanchanges to capture request and transform them postman collection. More information can be found here:Pynt doc
Quality PR: https://github.softwareag.com/IOTA/cumulocity-quality/pull/2488