Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AudioWorld#set_master_volume #5

Closed
wants to merge 1 commit into from
Closed

add AudioWorld#set_master_volume #5

wants to merge 1 commit into from

Conversation

ItsDoot
Copy link

@ItsDoot ItsDoot commented May 4, 2024

Open to bikeshedding.

@SolarLiner SolarLiner added the Feature New additions to the API surface label May 4, 2024
@SolarLiner SolarLiner added this to the 0.2 milestone May 4, 2024
@SolarLiner
Copy link
Owner

it's the only solution for now, but once we'll have tracks integrated I'd like this method to be put on the MainTrack entity instead. In fact you would be able to directly manipulate the main track with the Query<TrackHandle, With<MainTrack> or similar. I don't know if it makes sense to merge this now.

@SolarLiner
Copy link
Owner

Closing in favor of incoming work on the more general tracks integration being done soon.

@SolarLiner SolarLiner closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature New additions to the API surface
Projects
Bevy Audio v2 PRs
Status: In Progress
Milestone
0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ItsDoot @SolarLiner