Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate audio_control example #9

Merged
merged 7 commits into from
May 5, 2024

Conversation

GitGhillie
Copy link
Collaborator

Description

Recreated the audio_control example from Bevy.

Run with cargo run --example audio_control. I didn't add Windless Slopes.ogg because I wasn't sure if I could just do that, so let me know what the preference is there.

@SolarLiner
Copy link
Owner

I didn't add Windless Slopes.ogg because I wasn't sure if I could just do that

You bring a good point, and that makes me think that I added the drums asset to the examples without too much care for usage rights -- however since this crate is supposed to be upstreamed, it shouldn't be too much of an issue for Windless Slopes (and in fact all examples should use it instead). I definitely would ping a Bevy maintainer about it though!

@SolarLiner
Copy link
Owner

It looks like adding bevy as a dev-dependency broke the doc test in src/lib.rs:29, probably because the default features were turned back on. Not sure what's the best way to resolve it.

@SolarLiner SolarLiner added this to the 0.2 milestone May 5, 2024
GitGhillie and others added 4 commits May 5, 2024 20:41
Co-authored-by: Nathan Graule <solarliner@gmail.com>
Co-authored-by: Nathan Graule <solarliner@gmail.com>
@GitGhillie
Copy link
Collaborator Author

Hmm pushing commits doesn't seem to trigger a re-run of the CI so it's hard to try out a fix for the test...

I'll ping a maintainer about the Windless Slopes question tomorrow!

@SolarLiner
Copy link
Owner

re. Windless Slopes, it's from this pack, which has a CC0 1.0 license attached to it, so it's fine to include it here.

@SolarLiner
Copy link
Owner

pushing commits doesn't seem to trigger a re-run of the CI so it's hard to try out a fix for the test...

Looks like as a "first-time contributor" I'll need to approve all your runs? At least for your next PR it might work better 🙃

@GitGhillie
Copy link
Collaborator Author

Ha interesting, I'll try to reproduce it locally in the meantime

@GitGhillie
Copy link
Collaborator Author

I think I found the solution. By using no_run the doc example will still build but it won't try to run it. Which I think is the intention anyways

@GitGhillie
Copy link
Collaborator Author

Just in case you're waiting for me: I don't have a merge button 😛

@SolarLiner
Copy link
Owner

Ha, that's another thing I didn't know lol, it'd be nice if you could, I'll look into the settings.

@SolarLiner
Copy link
Owner

Well, I guess there's no other way than to have me be the one clicking on the button, so be it

@SolarLiner SolarLiner merged commit 184780c into SolarLiner:main May 5, 2024
4 checks passed
@GitGhillie GitGhillie deleted the audio-control-example branch May 5, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants