-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate audio_control example #9
Conversation
You bring a good point, and that makes me think that I added the drums asset to the examples without too much care for usage rights -- however since this crate is supposed to be upstreamed, it shouldn't be too much of an issue for Windless Slopes (and in fact all examples should use it instead). I definitely would ping a Bevy maintainer about it though! |
It looks like adding bevy as a dev-dependency broke the doc test in src/lib.rs:29, probably because the default features were turned back on. Not sure what's the best way to resolve it. |
Co-authored-by: Nathan Graule <solarliner@gmail.com>
Co-authored-by: Nathan Graule <solarliner@gmail.com>
Hmm pushing commits doesn't seem to trigger a re-run of the CI so it's hard to try out a fix for the test... I'll ping a maintainer about the Windless Slopes question tomorrow! |
re. |
Looks like as a "first-time contributor" I'll need to approve all your runs? At least for your next PR it might work better 🙃 |
Ha interesting, I'll try to reproduce it locally in the meantime |
I think I found the solution. By using |
Just in case you're waiting for me: I don't have a merge button 😛 |
Ha, that's another thing I didn't know lol, it'd be nice if you could, I'll look into the settings. |
Well, I guess there's no other way than to have me be the one clicking on the button, so be it |
Description
Recreated the audio_control example from Bevy.
Run with
cargo run --example audio_control
. I didn't addWindless Slopes.ogg
because I wasn't sure if I could just do that, so let me know what the preference is there.