Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (generation) Correu asincron #161

Merged
merged 3 commits into from
Jan 28, 2025
Merged

🐛 (generation) Correu asincron #161

merged 3 commits into from
Jan 28, 2025

Conversation

destanyol
Copy link
Contributor

Description

Single phrase summary of the pull request

Changes

  • Comprehensive list of changes (effect, not process)

Checklist

Justify any unchecked point:

  • Changed code is covered by tests.
  • Relevant changes are explained in the "Unreleased" section of the CHANGES.md file.
  • That section includes "Upgrade notes" with any config, dependency or deploy tweek needed on development and server setups.
  • Changes on the setup process (development, testing, production) have been updated in the proper documentation

Observations

Please, review

  • List of things authors emphasize to review

How to check the new features

Deploy notes

@destanyol destanyol requested a review from anxodio January 28, 2025 13:54
@@ -1676,7 +1678,13 @@ def send_mail(self, cursor, uid, id, model, template, investment_id=None, contex
from_id = from_id,
).dump())
else:
PETemplate.generate_mail(cursor, uid, template_id, id, context=ctx)
# PETemplate.generate_mail(cursor, uid, template_id, id, context=ctx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es pot esborrar, no?

@destanyol destanyol changed the title 🐛 (generation) Hot fix make mail async 🐛 (generation) Correu asincron Jan 28, 2025
@destanyol destanyol merged commit a1523d8 into master Jan 28, 2025
4 of 5 checks passed
@destanyol destanyol deleted the fix_mail_sending branch January 28, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants