[rend2] Fix ghoul2 related crash, when other model type was loaded in…

…stead
SomaZ · Mar 18, 2024 · 2846ba0 · 2846ba0
1 parent 4e70447
commit 2846ba0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/code/rd-rend2/G2_API.cpp b/code/rd-rend2/G2_API.cpp
@@ -2391,10 +2391,11 @@ qboolean G2_TestModelPointers(CGhoul2Info *ghlInfo) // returns true if the model
 	{
 		ghlInfo->mModel = RE_RegisterModel(ghlInfo->mFileName);
 		ghlInfo->currentModel = R_GetModelByHandle(ghlInfo->mModel);
-		if (ghlInfo->currentModel)
+		if (ghlInfo->currentModel &&
+			ghlInfo->currentModel->type == MOD_MDXM) //Rend2 - data is a union now, so we need to make sure it's also a glm that is loaded
 		{
-			//Rend2 - Not sure why, but we need MOD_MDXM here to stop ghoul2 crashes.
-			if (ghlInfo->currentModel->type == MOD_MDXM && ghlInfo->currentModel->data.glm && ghlInfo->currentModel->data.glm->header)
+			if (ghlInfo->currentModel->data.glm &&
+				ghlInfo->currentModel->data.glm->header)
 			{
 				mdxmHeader_t *mdxm = ghlInfo->currentModel->data.glm->header;
 				if (ghlInfo->currentModelSize)

diff --git a/codemp/rd-rend2/G2_API.cpp b/codemp/rd-rend2/G2_API.cpp
@@ -2988,7 +2988,8 @@ qboolean G2_TestModelPointers(CGhoul2Info *ghlInfo) // returns true if the model
 			ghlInfo->mModel = RE_RegisterModel(ghlInfo->mFileName);
 		}
 		ghlInfo->currentModel = R_GetModelByHandle(ghlInfo->mModel);
-		if (ghlInfo->currentModel)
+		if (ghlInfo->currentModel &&
+			ghlInfo->currentModel->type == MOD_MDXM) //Rend2 - data is a union now, so we need to make sure it's also a glm that is loaded
 		{
 			if (ghlInfo->currentModel->data.glm &&
 				ghlInfo->currentModel->data.glm->header)