Skip to content

Commit

Permalink
SONAR-20820 Remove socketTimeout from jdbcOverwrite.jdbcUrl's default…
Browse files Browse the repository at this point in the history 
… value
  • Loading branch information
@carminevassallo
carminevassallo committed Sep 25, 2024
1 parent 215d3bc commit befa34b
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 20 deletions.
1 change: 1 addition & 0 deletions charts/sonarqube-dce/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ All changes to this chart will be documented in this file.
* Support SONAR_OPENSHIFT telemetry env_var
* Update helm chart repo path in sources
* Support IS_HELM_AUTOSCALING_ENABLED telemetry env_var and rename SONAR_OPENSHIFT to IS_HELM_OPENSHIFT_ENABLED
* Remove socketTimeout from jdbcOverwrite.jdbcUrl's default value

## [10.6.0]
* Upgrade SonarQube to 10.6.0
Expand Down
2 changes: 2 additions & 0 deletions charts/sonarqube-dce/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ annotations:
description: "Update helm chart repo path in sources"
- kind: added
description: "Support IS_HELM_AUTOSCALING_ENABLED telemetry env_var and rename SONAR_OPENSHIFT to IS_HELM_OPENSHIFT_ENABLED"
- kind: changed
description: "Remove socketTimeout from jdbcOverwrite.jdbcUrl's default value"
artifacthub.io/links: |
- name: support
url: https://community.sonarsource.com/
Expand Down
18 changes: 9 additions & 9 deletions charts/sonarqube-dce/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -529,15 +529,15 @@ The following table lists the configurable parameters of the SonarQube chart and
### JDBC Overwrite
| Parameter | Description | Default |
| ------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------ | ------------------------------------------------------------- |
| `jdbcOverwrite.enable` | (DEPRECATED) Enable JDBC overwrites for external Databases (disables `postgresql.enabled`) ,Please use jdbcOverwrite.enabled instead | `false` |
| `jdbcOverwrite.enabled` | Enable JDBC overwrites for external Databases (disable `postgresql.enabled`) | `false` |
| `jdbcOverwrite.jdbcUrl` | The JDBC url to connect the external DB | `jdbc:postgresql://myPostgress/myDatabase?socketTimeout=1500` |
| `jdbcOverwrite.jdbcUsername` | The DB user that should be used for the JDBC connection | `sonarUser` |
| `jdbcOverwrite.jdbcPassword` | The DB password that should be used for the JDBC connection (Use this if you don't mind the DB password getting stored in plain text within the values file) | `sonarPass` |
| `jdbcOverwrite.jdbcSecretName` | Alternatively, use a pre-existing k8s secret containing the DB password | `None` |
| `jdbcOverwrite.jdbcSecretPasswordKey` | If the pre-existing k8s secret is used this allows the user to overwrite the 'key' of the password property in the secret | `None` |
| Parameter | Description | Default |
| ------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------ | ------------------------------------------ |
| `jdbcOverwrite.enable` | (DEPRECATED) Enable JDBC overwrites for external Databases (disables `postgresql.enabled`) ,Please use jdbcOverwrite.enabled instead | `false` |
| `jdbcOverwrite.enabled` | Enable JDBC overwrites for external Databases (disable `postgresql.enabled`) | `false` |
| `jdbcOverwrite.jdbcUrl` | The JDBC url to connect the external DB | `jdbc:postgresql://myPostgress/myDatabase` |
| `jdbcOverwrite.jdbcUsername` | The DB user that should be used for the JDBC connection | `sonarUser` |
| `jdbcOverwrite.jdbcPassword` | The DB password that should be used for the JDBC connection (Use this if you don't mind the DB password getting stored in plain text within the values file) | `sonarPass` |
| `jdbcOverwrite.jdbcSecretName` | Alternatively, use a pre-existing k8s secret containing the DB password | `None` |
| `jdbcOverwrite.jdbcSecretPasswordKey` | If the pre-existing k8s secret is used this allows the user to overwrite the 'key' of the password property in the secret | `None` |
### Bundled PostgreSQL Chart (DEPRECATED)
Expand Down
2 changes: 1 addition & 1 deletion charts/sonarqube-dce/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,7 @@ jdbcOverwrite:
# If enable the JDBC Overwrite, make sure to set `postgresql.enabled=false`
enabled: false
# The JDBC url of the external DB
jdbcUrl: "jdbc:postgresql://myPostgress/myDatabase?socketTimeout=1500"
jdbcUrl: "jdbc:postgresql://myPostgress/myDatabase"
# The DB user that should be used for the JDBC connection
jdbcUsername: "sonarUser"
# Use this if you don't mind the DB password getting stored in plain text within the values file
Expand Down
1 change: 1 addition & 0 deletions charts/sonarqube/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ All changes to this chart will be documented in this file.
* Support SONAR_OPENSHIFT telemetry env_var
* Update helm chart repo path in sources
* Changed SONAR_OPENSHIFT to IS_HELM_OPENSHIFT_ENABLED
* Remove socketTimeout from jdbcOverwrite.jdbcUrl's default value

## [10.6.0]
* Update SonarQube to 10.6.0
Expand Down
2 changes: 2 additions & 0 deletions charts/sonarqube/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ annotations:
description: "Update helm chart repo path in sources"
- kind: changed
description: "Changed SONAR_OPENSHIFT to IS_HELM_OPENSHIFT_ENABLED"
- kind: changed
description: "Remove socketTimeout from jdbcOverwrite.jdbcUrl's default value"
artifacthub.io/containsSecurityUpdates: "false"
artifacthub.io/images: |
- name: sonarqube
Expand Down
18 changes: 9 additions & 9 deletions charts/sonarqube/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -470,15 +470,15 @@ The following table lists the configurable parameters of the SonarQube chart and

### JDBC Overwrite

| Parameter | Description | Default |
| ------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------ | ------------------------------------------------------------- |
| `jdbcOverwrite.enable` | (DEPRECATED) Enable JDBC overwrites for external Databases (disables `postgresql.enabled`) ,Please use jdbcOverwrite.enabled instead | `false` |
| `jdbcOverwrite.enabled` | Enable JDBC overwrites for external Databases (disables `postgresql.enabled`) | `false` |
| `jdbcOverwrite.jdbcUrl` | The JDBC url to connect the external DB | `jdbc:postgresql://myPostgress/myDatabase?socketTimeout=1500` |
| `jdbcOverwrite.jdbcUsername` | The DB user that should be used for the JDBC connection | `sonarUser` |
| `jdbcOverwrite.jdbcPassword` | The DB password that should be used for the JDBC connection (Use this if you don't mind the DB password getting stored in plain text within the values file) | `sonarPass` |
| `jdbcOverwrite.jdbcSecretName` | Alternatively, use a pre-existing k8s secret containing the DB password | `None` |
| `jdbcOverwrite.jdbcSecretPasswordKey` | If the pre-existing k8s secret is used this allows the user to overwrite the 'key' of the password property in the secret | `None` |
| Parameter | Description | Default |
| ------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------ | ------------------------------------------ |
| `jdbcOverwrite.enable` | (DEPRECATED) Enable JDBC overwrites for external Databases (disables `postgresql.enabled`) ,Please use jdbcOverwrite.enabled instead | `false` |
| `jdbcOverwrite.enabled` | Enable JDBC overwrites for external Databases (disables `postgresql.enabled`) | `false` |
| `jdbcOverwrite.jdbcUrl` | The JDBC url to connect the external DB | `jdbc:postgresql://myPostgress/myDatabase` |
| `jdbcOverwrite.jdbcUsername` | The DB user that should be used for the JDBC connection | `sonarUser` |
| `jdbcOverwrite.jdbcPassword` | The DB password that should be used for the JDBC connection (Use this if you don't mind the DB password getting stored in plain text within the values file) | `sonarPass` |
| `jdbcOverwrite.jdbcSecretName` | Alternatively, use a pre-existing k8s secret containing the DB password | `None` |
| `jdbcOverwrite.jdbcSecretPasswordKey` | If the pre-existing k8s secret is used this allows the user to overwrite the 'key' of the password property in the secret | `None` |

### Bundled PostgreSQL Chart (DEPRECATED)

Expand Down
2 changes: 1 addition & 1 deletion charts/sonarqube/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ jdbcOverwrite:
# If enable the JDBC Overwrite, make sure to set `postgresql.enabled=false`
enabled: false
# The JDBC url of the external DB
jdbcUrl: "jdbc:postgresql://myPostgress/myDatabase?socketTimeout=1500"
jdbcUrl: "jdbc:postgresql://myPostgress/myDatabase"
# The DB user that should be used for the JDBC connection
jdbcUsername: "sonarUser"
# Use this if you don't mind the DB password getting stored in plain text within the values file
Expand Down

0 comments on commit befa34b

Please sign in to comment.