Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONAR-22219 add extra volume for dce ApplicationNodes #559

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

jCOTINEAU
Copy link
Collaborator

No description provided.

@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-22219-dce-extravolumes branch from 2cd00ac to 87156ae Compare September 25, 2024 14:31
@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-22219-dce-extravolumes branch from 87156ae to dc6c8cc Compare September 26, 2024 07:11
Copy link
Collaborator

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jCOTINEAU. we should update the Readme with the new parameters.

@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-22219-dce-extravolumes branch from ff1e9ed to 3512f4a Compare September 26, 2024 13:21
Copy link
Collaborator

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionalities work as expected. A small comment remains. After fixing that, the PR can be merged!

@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-22219-dce-extravolumes branch 8 times, most recently from a26304a to fe9bdf3 Compare September 26, 2024 15:13
@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-22219-dce-extravolumes branch from fe9bdf3 to 4db8ce7 Compare September 26, 2024 15:19
Copy link

Copy link
Collaborator

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@jCOTINEAU jCOTINEAU merged commit be4df7f into master Sep 27, 2024
9 checks passed
@jCOTINEAU jCOTINEAU deleted the feature/jc/SONAR-22219-dce-extravolumes branch September 27, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants