SONAR-23627 improve initsysctl fail logic trigger 572 #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jCOTINEAU
force-pushed
the
community/jc/SONAR-23627-improve-initsysctl-fail-logic
branch
4 times, most recently
from
55ba5c2 to
6ebfaa0
Compare
carminevassallo
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Great improvement!
We notice that the conversion to int introduces a small inaccuracy in the case of very big numbers. However, we are talking about cases that are exceptional and that we are considering to "forbid" by not letting users modify the default parameters required by Elasticsearch.
jCOTINEAU
force-pushed
the
community/jc/SONAR-23627-improve-initsysctl-fail-logic
branch
from
8630c1a to
2e6ba7f
Compare
|
jCOTINEAU
deleted the
community/jc/SONAR-23627-improve-initsysctl-fail-logic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.