SONAR-23559 Improves editions and versions setting for sonarqube chart #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davividal
requested review from
jCOTINEAU and
carminevassallo
and removed request for
jCOTINEAU
carminevassallo
force-pushed
the
dkv/sonar-23559
branch
2 times, most recently
from
816a8ee to
cfbb48e
Compare
carminevassallo
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Hi @davividal,
the basic logic works, I could validate locally 🎉
However, there are a few things that I'd suggest we improve. Please let me know your opinion.
davividal
force-pushed
the
dkv/sonar-23559
branch
3 times, most recently
from
c0667c1 to
4c9df46
Compare
davividal
force-pushed
the
dkv/sonar-23559
branch
2 times, most recently
from
e9d0447 to
d3779c6
Compare
carminevassallo
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Great job, @davividal!
A few little things to tune:
- when we don't set any edition, we now just display "You must choose an 'edition' to install: 'developer' or 'enterprise'." At this stage we should also mention that people that wanna try the communityBuild they can set the other parameter
- the README.md of the chart is outdated as it contains references to the
communityedition. We should clean it up, also removing the parts where we mention that this edition is deprecated in favor of communityBuild. It's now basically a substitution and not a deprecation anymore.
davividal
force-pushed
the
dkv/sonar-23559
branch
from
0944e7a to
5ea337e
Compare
davividal
force-pushed
the
dkv/sonar-23559
branch
from
5ea337e to
64d927e
Compare
carminevassallo
approved these changes
Jan 9, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONAR-23559