-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONAR-24105 remove 9.9 deprecated feature #616
SONAR-24105 remove 9.9 deprecated feature #616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jCOTINEAU,
I think we can delete more :) If I look at the latest sonarqube LTS, we have also image.pullSecret
and postgresql.postgresqlServer
to be removed. On the latest sonarqube-dce LTS we have image.pullSecret
on both application and search nodes.
indeed, i completely overlooked those, completely missed the search, might have made a wrong checkout. |
f6805c2
to
77820fc
Compare
Quality Gate passedIssues Measures |
@@ -223,7 +223,7 @@ metadata: | |||
heritage: Helm | |||
data: | |||
SONAR_JDBC_USERNAME: sonarUser | |||
SONAR_JDBC_URL: "jdbc:postgresql://%!s(<nil>):5432/sonarDB" | |||
SONAR_JDBC_URL: "jdbc:postgresql://:5432/sonarDB" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here this highlight a problem we had before, in this test case we have no jdbcoverwrite as well as postgresql.enabled=false.
Hence the default data in the configmap does not make sense as no database as been configured.
i am creating a hardening ticket to ensure all our files, config map, secret and so on, are created only when it make sense.
Here for example the configmap should exist only if jdbcoverwrite or postgresql.enabled, and should fail fast in dce
SONAR-24105
Part of
Please ensure your pull request adheres to the following guidelines:
CHANGELOG.md
file of the respected chart as well as theChart.yaml