-
Notifications
You must be signed in to change notification settings - Fork 33
Create rule S8346: Increment and decrement operators (++/--) should not be used with floating point variables. #5951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-actions
wants to merge
5
commits into
master
Choose a base branch
from
rule/add-RSPEC-S8346
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasz-tylenda-sonarsource
requested changes
Dec 3, 2025
efbcbb6 to
0f80326
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for:
Description
Increment and decrement operators (
++and--) shouldn't be used with floating-point variables (likefloatordouble). While the language allows it, the usage is not idiomatic and most developers intuitively expectx++to apply to integer types. Using it on a float violates this common expectation and can lead to misleading code.In particular floating point arithmetic has some non-intuitive properties, which can lead to unexpected bugs. For example, the following loop will not terminate:
This happens because
floathas only 24 bits of precision and once a number gets large enough, adding1.0becomes insignificant.The problem would not occur if
intis used instead offloat, even though both bytes occupy 32 bits.Noncompliant code
Compliant code