Create rule S8347: ASP.NET applications should prefer file providers over direct file access (APPSEC-2834) #5953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egon-okerman-sonarsource
changed the title
egon-okerman-sonarsource
force-pushed
the
rule/add-RSPEC-S8347
branch
from
4fd4bea to
1d65429
Compare
daniel-teuchert-sonarsource
approved these changes
Dec 8, 2025
Contributor
daniel-teuchert-sonarsource
left a comment
daniel-teuchert-sonarsource
left a comment
There was a problem hiding this comment.
LGTM!
I guess because we are not raising with a taint flow here it is also okay to not map any security standard to it right?
Otherwise we could also use this rule as an example for defining the new process of mapping standards.
Contributor
|
@daniel-teuchert-sonarsource I simply don't know the process at this point of adding rules to existing standards, so I left it out. It would be a good example, I do agree. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: