SCAN4NET-18 Better messages for Multi-file analysis (#2156)

Tests/SonarScanner.MSBuild.PostProcessor.Test/PostProcessorTests.cs

@@ -92,15 +92,15 @@ public void PostProc_NoProjectsToAnalyze_NoExecutionTriggered()
         context.TfsProcessor.AssertNotExecuted();
         context.Scanner.AssertNotExecuted();
         context.Logger.AssertErrorsLogged(0);
-        context.Logger.AssertSingleWarningExists("""Multi-Language analysis is enabled. If this was not intended, please set "/d:sonar.scanner.scanAll=false" in the begin step.""");
+        context.Logger.AssertSingleWarningExists("""Multi-Language analysis is enabled. If this was not intended and you have issues such as hitting your LOC limit or analyzing unwanted files, please set "/d:sonar.scanner.scanAll=false" in the begin step.""");
         context.VerifyTargetsUninstaller();
 
         fileWrapper.Received(1).WriteAllText(
              Path.Combine(context.Settings.SonarOutputDirectory, FileConstants.UIWarningsFileName),
              """
              [
                {
-                 "text": "Multi-Language analysis is enabled. If this was not intended, please set \"/d:sonar.scanner.scanAll=false\" in the begin step."
+                 "text": "Multi-Language analysis is enabled. If this was not intended and you have issues such as hitting your LOC limit or analyzing unwanted files, please set \"/d:sonar.scanner.scanAll=false\" in the begin step."
                }
              ]
              """);
@@ -192,7 +192,8 @@ public void PostProc_ValidArgsPassedThrough()
         context.Scanner.AssertExecuted();
         context.Scanner.SuppliedCommandLineArgs.Should().Equal(expectedArgs, "Unexpected command line args passed to the sonar-scanner");
         context.Logger.AssertErrorsLogged(0);
-        context.Logger.AssertSingleWarningExists("""Multi-Language analysis is enabled. If this was not intended, please set "/d:sonar.scanner.scanAll=false" in the begin step.""");
+        context.Logger.AssertSingleWarningExists("""Multi-Language analysis is enabled. """ +
+            """If this was not intended and you have issues such as hitting your LOC limit or analyzing unwanted files, please set "/d:sonar.scanner.scanAll=false" in the begin step.""");
 
         context.VerifyTargetsUninstaller();
     }

Tests/SonarScanner.MSBuild.Shim.Test/PropertiesFileGeneratorTests.cs

@@ -865,7 +865,7 @@ public void TryWriteProperties_WhenThereIsNoCommonPath_LogsError()
             // create a project in the test run directory and a second one in the temp folder.
             sut.TryWriteProperties(new PropertiesWriter(config, this.logger), [firstProjectInfo, secondProjectInfo], out _);
 
-            logger.AssertErrorLogged("The project base directory cannot be automatically detected. Please specify the `sonar.projectBaseDir` on the begin step.");
+            logger.AssertErrorLogged("""The project base directory cannot be automatically detected. Please specify the "/d:sonar.projectBaseDir" on the begin step.""");
         }
 
         [TestMethod]

its/src/test/java/com/sonar/it/scanner/msbuild/sonarqube/ScannerMSBuildTest.java

@@ -1101,7 +1101,7 @@ void checkMultiLanguageSupportReact() throws Exception {
       Arrays.asList(
         new EnvironmentVariable("AGENT_BUILDDIRECTORY", ""),
         new EnvironmentVariable("BUILD_SOURCESDIRECTORY", "")),
-      TestUtils.TIMEOUT_LIMIT,
+      TestUtils.TIMEOUT_LIMIT * 5, // Longer timeout because of npm install
       "/t:Restore,Rebuild",
       "MultiLanguageSupportReact.csproj"
     );
@@ -1158,7 +1158,7 @@ void checkMultiLanguageSupportAngular() throws Exception {
       Arrays.asList(
         new EnvironmentVariable("AGENT_BUILDDIRECTORY", ""),
         new EnvironmentVariable("BUILD_SOURCESDIRECTORY", "")),
-      TestUtils.TIMEOUT_LIMIT,
+      TestUtils.TIMEOUT_LIMIT * 5, // Longer timeout because of npm install
       "/t:Restore,Rebuild",
       "MultiLanguageSupportAngular.csproj"
     );
@@ -1252,7 +1252,7 @@ private void assertOnlyMultiFileAnalysisWarning(BuildResult buildResult) {
     var warnings = TestUtils.getAnalysisWarningsTask(ORCHESTRATOR, buildResult);
     assertThat(warnings.getStatus()).isEqualTo(Ce.TaskStatus.SUCCESS);
     assertThat(warnings.getWarningsList()).containsExactly(
-      "Multi-Language analysis is enabled. If this was not intended, please set \"/d:sonar.scanner.scanAll=false\" in the begin step.");
+      "Multi-Language analysis is enabled. If this was not intended and you have issues such as hitting your LOC limit or analyzing unwanted files, please set \"/d:sonar.scanner.scanAll=false\" in the begin step.");
   }
 
   private void runCSharpSharedFileWithOneProjectUsingProjectBaseDir(Function<Path, String> getProjectBaseDir)

src/SonarScanner.MSBuild.PostProcessor/Resources.resx

@@ -188,6 +188,6 @@ Config file: {5}</value>
     <value>Cannot process the code coverage information. Look at the previous warnings for details.</value>
   </data>
   <data name="WARN_UI_ScanAllAnalysisEnabled" xml:space="preserve">
-    <value>Multi-Language analysis is enabled. If this was not intended, please set "/d:sonar.scanner.scanAll=false" in the begin step.</value>
+    <value>Multi-Language analysis is enabled. If this was not intended and you have issues such as hitting your LOC limit or analyzing unwanted files, please set "/d:sonar.scanner.scanAll=false" in the begin step.</value>
   </data>
 </root>

src/SonarScanner.MSBuild.Shim/Resources.resx

@@ -222,7 +222,7 @@ Possible causes:
     <value>File was referenced by the following projects: '{0}'.</value>
   </data>
   <data name="ERR_ProjectBaseDirCannotBeAutomaticallyDetected" xml:space="preserve">
-    <value>The project base directory cannot be automatically detected. Please specify the `sonar.projectBaseDir` on the begin step.</value>
+    <value>The project base directory cannot be automatically detected. Please specify the "/d:sonar.projectBaseDir" on the begin step.</value>
   </data>
   <data name="ERR_ProjectBaseDirDoesNotExist" xml:space="preserve">
     <value>The project base directory doesn't exist.</value>