-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCCPPGHA-2 Support macOS ARM runners #55
Conversation
9179e31
to
c358d81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side! Could you check the dev checklist and make sure that all items are checked before we go ahead and ask for a review from AE? Especially the one regarding commit messages.
5f493cc
to
c358d81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to squash the commits and have it start with the ticket number
c358d81
to
d9322cf
Compare
Hi, I have squashed the commits, and also did so for the other PR SonarSource/sonarqube-github-c-cpp#8 , let me know if there are any other changes I should make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@antoine-vinot-sonarsource I have merged this pr, what is your (AE) process for the status jira ticket? (same for the SQ pr) Also as a side note, do you usually do the release of the action after such updates? Right now the changes are not in the latest release and therefore not available by users (or by repos in https://github.com/sonarsource-cfamily-examples) |
Hey @enzo-pellegrini, sorry for the late answer!
We usually close the ticket once the PR is merged.
We don't have a well-defined process for releasing those repositories at the moment. Thus, my guess is that we will release it anytime we think it makes sense. |
List of checkpoint to verify/do before merging a PR.
Dev checklist
Reviewer checklist
Steps to validate this PR
Fill-in how you performed the validation, and how the reviewer can replicate it: