Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCCPPGHA-2 Support macOS ARM runners #55

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

friedbyalice
Copy link
Contributor

@friedbyalice friedbyalice commented May 6, 2024

List of checkpoint to verify/do before merging a PR.

Dev checklist

  • Write/update tests
  • Functional validation
  • Public documentation update
  • Private documentation update
  • Clean commits (should start with a ticket number, clear message, no fixup, wip)
  • Maximize code coverage as much as possible

Reviewer checklist

  • Code review
  • Functional validation
  • Check commits are clean

Steps to validate this PR

Fill-in how you performed the validation, and how the reviewer can replicate it:

  • [ ]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side! Could you check the dev checklist and make sure that all items are checked before we go ahead and ask for a review from AE? Especially the one regarding commit messages.

Copy link

@antoine-vinot-sonarsource antoine-vinot-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to squash the commits and have it start with the ticket number

@friedbyalice friedbyalice force-pushed the vp/supportMacOS_ARM64 branch from c358d81 to d9322cf Compare May 8, 2024 08:44
@friedbyalice
Copy link
Contributor Author

Hi, I have squashed the commits, and also did so for the other PR SonarSource/sonarqube-github-c-cpp#8 , let me know if there are any other changes I should make.

Copy link

@antoine-vinot-sonarsource antoine-vinot-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@friedbyalice friedbyalice merged commit 8a10879 into main May 13, 2024
10 checks passed
@friedbyalice
Copy link
Contributor Author

friedbyalice commented May 13, 2024

@antoine-vinot-sonarsource I have merged this pr, what is your (AE) process for the status jira ticket? (same for the SQ pr)

Also as a side note, do you usually do the release of the action after such updates? Right now the changes are not in the latest release and therefore not available by users (or by repos in https://github.com/sonarsource-cfamily-examples)

@antoine-vinot-sonarsource

Hey @enzo-pellegrini, sorry for the late answer!

I have merged this pr, what is your (AE) process for the status jira ticket? (same for the SQ pr)

We usually close the ticket once the PR is merged.

Also as a side note, do you usually do the release of the action after such updates? Right now the changes are not in the latest release and therefore not available by users (or by repos in https://github.com/sonarsource-cfamily-examples)

We don't have a well-defined process for releasing those repositories at the moment. Thus, my guess is that we will release it anytime we think it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants