Remove override of solution close logic from SharedBindingSuggestionS…

…ervice
SonarSource · Oct 28, 2024 · 079db0d · 079db0d
1 parent 1b1701c
commit 079db0d
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 17 deletions.
diff --git a/src/ConnectedMode.UnitTests/Binding/Suggestion/SuggestSharedBindingGoldBarTests.cs b/src/ConnectedMode.UnitTests/Binding/Suggestion/SuggestSharedBindingGoldBarTests.cs
@@ -71,7 +71,7 @@ public void Show_GeneratesCorrectNotificationStructure()
         notificationActions[1].CommandText.Should().Be(BindingStrings.SharedBindingSuggestionInfoOptionText);
         notificationActions[1].ShouldDismissAfterAction.Should().BeFalse();
         notificationActions[2].Should().BeSameAs(doNotShowAgainMock.Object);
-        notification.CloseOnSolutionClose.Should().Be(false);
+        notification.CloseOnSolutionClose.Should().Be(true);
     }
 
 

diff --git a/src/ConnectedMode/Binding/Suggestion/SuggestSharedBindingGoldBar.cs b/src/ConnectedMode/Binding/Suggestion/SuggestSharedBindingGoldBar.cs
@@ -65,10 +65,7 @@ public void Show(ServerType serverType, Action onConnectHandler)
                     new NotificationAction(BindingStrings.SharedBindingSuggestionConnectOptionText, _ => onConnectHandler(), true),
                     new NotificationAction(BindingStrings.SharedBindingSuggestionInfoOptionText, _ => OnLearnMore(), false),
                     doNotShowAgainNotificationAction
-                ],
-                // Prevent INotificationService from handling the on solution change events
-                // as this is exceptionally overriden by the SharedBindingSuggestionService
-                closeOnSolutionClose: false);
+                ]);
 
             notificationService.ShowNotification(notification);
         }

diff --git a/src/Integration.UnitTests/MefServices/SharedBindingSuggestionServiceTests.cs b/src/Integration.UnitTests/MefServices/SharedBindingSuggestionServiceTests.cs
@@ -147,14 +147,6 @@ public void ActiveSolutionChanged_SolutionIsOpened_ShowsGoldBarAndShowManageBind
         showAction.Should().NotBeNull();
         connectedModeManager.Received(1).ShowManageBindingDialog(true);
     }
-
-    [TestMethod]
-    public void ActiveSolutionChanged_SolutionIsClosed_ClosesNotification()
-    {
-        RaiseActiveSolutionChanged(false);
-
-        suggestSharedBindingGoldBar.Received().Close();
-    }
 
     private void RaiseActiveSolutionChanged(bool isSolutionOpened)
     {

diff --git a/src/Integration/MefServices/SharedBindingSuggestionService.cs b/src/Integration/MefServices/SharedBindingSuggestionService.cs
@@ -86,10 +86,6 @@ private void OnActiveSolutionChanged(object sender, ActiveSolutionChangedEventAr
             {
                 Suggest();
             }
-            else
-            {
-                suggestSharedBindingGoldBar.Close();
-            }
         }
     }
 }
-Original file line number
+Diff line change
@@ Expand Up @@
                 {
                     Suggest();
                 }
-                else
-                {
-                    suggestSharedBindingGoldBar.Close();
-                }
             }
         }
     }