SLVS-1410 Split IObsoleteConfigurationProvider from IConfigurationPro…

…vider

src/ConnectedMode.UnitTests/Migration/MigrationCheckerTests.cs

@@ -160,7 +160,7 @@ private static MigrationChecker CreateTestSubject(IActiveSolutionTracker activeS
 
             if (configurationProvider == null)
             {
-                var configurationProviderMock = new Mock<IObsoleteConfigurationProvider>();
+                var configurationProviderMock = new Mock<IConfigurationProvider>();
                 configurationProviderMock.Setup(x => x.GetConfiguration()).Returns(CreateBindingConfiguration(SonarLintMode.Standalone));
 
                 configurationProvider = configurationProviderMock.Object;

src/ConnectedMode/Migration/IObsoleteConfigurationProvider.cs

@@ -31,7 +31,11 @@ namespace SonarLint.VisualStudio.ConnectedMode.Migration
     /// new format.
     /// See https://github.com/SonarSource/sonarlint-visualstudio/issues/4171
     /// </remarks>
-    public interface IObsoleteConfigurationProvider : IConfigurationProvider
+    public interface IObsoleteConfigurationProvider
     {
+        /// <summary>
+        /// Returns the binding configuration for the current solution
+        /// </summary>
+        LegacyBindingConfiguration GetConfiguration();
     }
 }

src/Core/Binding/LegacyBindingConfiguration.cs

@@ -23,6 +23,7 @@
 
 namespace SonarLint.VisualStudio.Core.Binding
 {
+    [Obsolete("Use BindingConfiguration instead. This class is kept for backwards compatibility with binding formats that don't support ServerConnection as a separate entity")]
     public sealed class LegacyBindingConfiguration : IEquatable<LegacyBindingConfiguration>
     {
         public static readonly LegacyBindingConfiguration Standalone = new LegacyBindingConfiguration(null, SonarLintMode.Standalone, null);