SLVS-1688 Update Quality Profiles on solution open

SonarSource · Dec 10, 2024 · 1641c37 · 1641c37
1 parent 69acfc6
commit 1641c37
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/ConnectedMode.UnitTests/BoundSolutionUpdateHandlerTests.cs b/src/ConnectedMode.UnitTests/BoundSolutionUpdateHandlerTests.cs
@@ -20,6 +20,7 @@
 
 using System;
 using SonarLint.VisualStudio.ConnectedMode.Hotspots;
+using SonarLint.VisualStudio.ConnectedMode.QualityProfiles;
 using SonarLint.VisualStudio.ConnectedMode.Suppressions;
 using SonarLint.VisualStudio.Core.Binding;
 using SonarLint.VisualStudio.TestInfrastructure;
@@ -35,7 +36,8 @@ public void MefCtor_CheckIsExported()
             MefTestHelpers.CheckTypeCanBeImported<BoundSolutionUpdateHandler, BoundSolutionUpdateHandler>(
                 MefTestHelpers.CreateExport<IActiveSolutionBoundTracker>(),
                 MefTestHelpers.CreateExport<ISuppressionIssueStoreUpdater>(),
-                MefTestHelpers.CreateExport<IServerHotspotStoreUpdater>());
+                MefTestHelpers.CreateExport<IServerHotspotStoreUpdater>(),
+                MefTestHelpers.CreateExport<IQualityProfileUpdater>());
         }
 
         [TestMethod]
@@ -49,7 +51,7 @@ public void Ctor_SubscribesToEvents()
         {
             var activeSolutionTracker = new Mock<IActiveSolutionBoundTracker>();
 
-            _ = new BoundSolutionUpdateHandler(activeSolutionTracker.Object, Mock.Of<ISuppressionIssueStoreUpdater>(), Mock.Of<IServerHotspotStoreUpdater>());
+            _ = new BoundSolutionUpdateHandler(activeSolutionTracker.Object, Mock.Of<ISuppressionIssueStoreUpdater>(), Mock.Of<IServerHotspotStoreUpdater>(), Mock.Of<IQualityProfileUpdater>());
 
             activeSolutionTracker.VerifyAdd(x => x.SolutionBindingChanged += It.IsAny<EventHandler<ActiveSolutionBindingEventArgs>>(), Times.Once);
             activeSolutionTracker.VerifyAdd(x => x.SolutionBindingUpdated += It.IsAny<EventHandler>(), Times.Once);
@@ -61,24 +63,27 @@ public void InvokeEvents_ServerStoreUpdatersAreCalled()
             var activeSolutionTracker = new Mock<IActiveSolutionBoundTracker>();
             var suppressionIssueStoreUpdater = new Mock<ISuppressionIssueStoreUpdater>();
             var serverHotspotStoreUpdater = new Mock<IServerHotspotStoreUpdater>();
+            var qualityProfileUpdater = new Mock<IQualityProfileUpdater>();
 
-            _ = new BoundSolutionUpdateHandler(activeSolutionTracker.Object, suppressionIssueStoreUpdater.Object, serverHotspotStoreUpdater.Object);
+            _ = new BoundSolutionUpdateHandler(activeSolutionTracker.Object, suppressionIssueStoreUpdater.Object, serverHotspotStoreUpdater.Object, qualityProfileUpdater.Object);
 
             activeSolutionTracker.Raise(x => x.SolutionBindingChanged += null, new ActiveSolutionBindingEventArgs(BindingConfiguration.Standalone));
             suppressionIssueStoreUpdater.Verify(x => x.UpdateAllServerSuppressionsAsync(), Times.Once);
             serverHotspotStoreUpdater.Verify(x => x.UpdateAllServerHotspotsAsync(), Times.Once);
+            qualityProfileUpdater.Verify(x => x.UpdateAsync(), Times.Once);
 
             activeSolutionTracker.Raise(x => x.SolutionBindingUpdated += null, EventArgs.Empty);
             suppressionIssueStoreUpdater.Verify(x => x.UpdateAllServerSuppressionsAsync(), Times.Exactly(2));
             serverHotspotStoreUpdater.Verify(x => x.UpdateAllServerHotspotsAsync(), Times.Exactly(2));
+            qualityProfileUpdater.Verify(x => x.UpdateAsync(), Times.Exactly(2));
         }
 
         [TestMethod]
         public void Dispose_UnsubscribesToEvent()
         {
             var activeSolutionTracker = new Mock<IActiveSolutionBoundTracker>();
 
-            var testSubject = new BoundSolutionUpdateHandler(activeSolutionTracker.Object, Mock.Of<ISuppressionIssueStoreUpdater>(), Mock.Of<IServerHotspotStoreUpdater>());
+            var testSubject = new BoundSolutionUpdateHandler(activeSolutionTracker.Object, Mock.Of<ISuppressionIssueStoreUpdater>(), Mock.Of<IServerHotspotStoreUpdater>(), Mock.Of<IQualityProfileUpdater>());
 
             testSubject.Dispose();
 

diff --git a/src/ConnectedMode/BoundSolutionUpdateHandler.cs b/src/ConnectedMode/BoundSolutionUpdateHandler.cs
@@ -22,6 +22,7 @@
 using System.ComponentModel.Composition;
 using Microsoft.VisualStudio.Threading;
 using SonarLint.VisualStudio.ConnectedMode.Hotspots;
+using SonarLint.VisualStudio.ConnectedMode.QualityProfiles;
 using SonarLint.VisualStudio.ConnectedMode.Suppressions;
 using SonarLint.VisualStudio.Core.Binding;
 
@@ -34,17 +35,20 @@ internal sealed class BoundSolutionUpdateHandler : IDisposable
         private readonly IActiveSolutionBoundTracker activeSolutionBoundTracker;
         private readonly ISuppressionIssueStoreUpdater suppressionIssueStoreUpdater;
         private readonly IServerHotspotStoreUpdater serverHotspotStoreUpdater;
+        private readonly IQualityProfileUpdater qualityProfileUpdater;
 
         private bool disposed;
 
         [ImportingConstructor]
         public BoundSolutionUpdateHandler(IActiveSolutionBoundTracker activeSolutionBoundTracker,
             ISuppressionIssueStoreUpdater suppressionIssueStoreUpdater,
-            IServerHotspotStoreUpdater serverHotspotStoreUpdater)
+            IServerHotspotStoreUpdater serverHotspotStoreUpdater,
+            IQualityProfileUpdater qualityProfileUpdater)
         {
             this.activeSolutionBoundTracker = activeSolutionBoundTracker;
             this.suppressionIssueStoreUpdater = suppressionIssueStoreUpdater;
             this.serverHotspotStoreUpdater = serverHotspotStoreUpdater;
+            this.qualityProfileUpdater = qualityProfileUpdater;
 
             this.activeSolutionBoundTracker.SolutionBindingChanged += OnSolutionBindingChanged;
             this.activeSolutionBoundTracker.SolutionBindingUpdated += OnSolutionBindingUpdated;
@@ -58,6 +62,7 @@ private void TriggerUpdate()
         {
             suppressionIssueStoreUpdater.UpdateAllServerSuppressionsAsync().Forget();
             serverHotspotStoreUpdater.UpdateAllServerHotspotsAsync().Forget();
+            qualityProfileUpdater.UpdateAsync().Forget();
         }
 
         public void Dispose()