Skip to content

Commit

Permalink
Replace hardcoded url with Resource
Browse files Browse the repository at this point in the history
  • Loading branch information
vnaskos-sonar committed Sep 23, 2024
1 parent 075eb6a commit 2d08fca
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Core/Binding/ServerConnection.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ private ServerConnection(string id, ServerConnectionSettings settings = null, IC

public sealed class SonarCloud : ServerConnection
{
private const string SonarCloudUrl = "https://sonarcloud.io";
private static readonly string SonarCloudUrl = CoreStrings.SonarCloudUrl;

public SonarCloud(string organizationKey, ServerConnectionSettings settings = null, ICredentials credentials = null)
: base(OrganizationKeyToId(organizationKey), settings, credentials)
Expand Down
10 changes: 9 additions & 1 deletion src/Core/CoreStrings.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/Core/CoreStrings.resx
Original file line number Diff line number Diff line change
Expand Up @@ -190,4 +190,7 @@
<data name="NoGitFolder" xml:space="preserve">
<value>Solution/folder is not in a git repository</value>
</data>
<data name="SonarCloudUrl" xml:space="preserve">
<value>https://sonarcloud.io</value>
</data>
</root>

0 comments on commit 2d08fca

Please sign in to comment.