Enable FixSuggestion feature flag

SonarSource · Oct 2, 2024 · a3750b2 · a3750b2
1 parent 1e6caa2
commit a3750b2
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 8 deletions.
diff --git a/src/Integration.UnitTests/SLCore/SLCoreConstantsProviderTests.cs b/src/Integration.UnitTests/SLCore/SLCoreConstantsProviderTests.cs
@@ -66,7 +66,7 @@ public void ClientConstants_ShouldBeExpected()
     public void FeatureFlags_ShouldBeExpected()
     {
         var testSubject = CreateTestSubject();
-        var expectedFeatureFlags = new FeatureFlagsDto(true, true, true, true, false, false, true, true);
+        var expectedFeatureFlags = new FeatureFlagsDto(true, true, true, true, false, false, true, true, true);
         var actual = testSubject.FeatureFlags;
 
         actual.Should().BeEquivalentTo(expectedFeatureFlags);

diff --git a/src/Integration/SLCore/SLCoreConstantsProvider.cs b/src/Integration/SLCore/SLCoreConstantsProvider.cs
@@ -42,7 +42,7 @@ public SLCoreConstantsProvider(IVsInfoProvider vsInfoProvider)
 
         public ClientConstantsDto ClientConstants => new(vsInfoProvider.Name, $"SonarLint Visual Studio/{VersionHelper.SonarLintVersion}", Process.GetCurrentProcess().Id);
 
-        public FeatureFlagsDto FeatureFlags => new(true, true, true, true, false, false, true, true);
+        public FeatureFlagsDto FeatureFlags => new(true, true, true, true, false, false, true, true, true);
 
         public TelemetryClientConstantAttributesDto TelemetryConstants => new("visualstudio", "SonarLint Visual Studio", VersionHelper.SonarLintVersion, VisualStudioHelpers.VisualStudioVersion, new Dictionary<string, object>
         {

diff --git a/src/SLCore.IntegrationTests/SLCoreTestRunner.cs b/src/SLCore.IntegrationTests/SLCoreTestRunner.cs
@@ -93,7 +93,7 @@ public void Start()
             var constantsProvider = Substitute.For<ISLCoreConstantsProvider>();
             constantsProvider.ClientConstants.Returns(new ClientConstantsDto("SLVS_Integration_Tests",
                 $"SLVS_Integration_Tests/{VersionHelper.SonarLintVersion}", Process.GetCurrentProcess().Id));
-            constantsProvider.FeatureFlags.Returns(new FeatureFlagsDto(true, true, false, true, false, false, true, false));
+            constantsProvider.FeatureFlags.Returns(new FeatureFlagsDto(true, true, false, true, false, false, true, false, false));
             constantsProvider.TelemetryConstants.Returns(new TelemetryClientConstantAttributesDto("slvs_integration_tests", "SLVS Integration Tests",
                 VersionHelper.SonarLintVersion, "17.0", new()));
             SetLanguagesConfigurationToDefaults(constantsProvider);

diff --git a/src/SLCore.UnitTests/SLCoreInstanceHandleTests.cs b/src/SLCore.UnitTests/SLCoreInstanceHandleTests.cs
@@ -44,7 +44,7 @@ public class SLCoreInstanceHandleTests
     private const string UserHome = "userHomeSl";
 
     private static readonly ClientConstantsDto ClientConstants = new(default, default, default);
-    private static readonly FeatureFlagsDto FeatureFlags = new(default, default, default, default, default, default, default, default);
+    private static readonly FeatureFlagsDto FeatureFlags = new(default, default, default, default, default, default, default, default, default);
     private static readonly TelemetryClientConstantAttributesDto TelemetryConstants = new(default, default, default, default, default);
 
     private static readonly SonarQubeConnectionConfigurationDto SonarQubeConnection1 = new("sq1", true, "http://localhost/");

diff --git a/src/SLCore.UnitTests/Service/Lifecycle/InitializeParamsTests.cs b/src/SLCore.UnitTests/Service/Lifecycle/InitializeParamsTests.cs
@@ -18,7 +18,6 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
-using System.Collections.Generic;
 using Newtonsoft.Json;
 using SonarLint.VisualStudio.SLCore.Common.Models;
 using SonarLint.VisualStudio.SLCore.Service.Connection.Models;
@@ -37,7 +36,7 @@ public void Serialize_AsExpected()
         var testSubject = new InitializeParams(
             new ClientConstantsDto("TESTname", "TESTagent", 11223344),
             new HttpConfigurationDto(new SslConfigurationDto()),
-            new FeatureFlagsDto(false, true, false, true, false, true, false, false),
+            new FeatureFlagsDto(false, true, false, true, false, true, false, false, false),
             "storageRoot",
             "workDir",
             ["myplugin1", "myplugin2"],
@@ -77,7 +76,8 @@ [new SonarCloudConnectionConfigurationDto("con2", false, "organization1")],
                                     "shouldManageServerSentEvents": false,
                                     "enableDataflowBugDetection": true,
                                     "shouldManageFullSynchronization": false,
-                                    "enableTelemetry": false
+                                    "enableTelemetry": false,
+                                    "canOpenFixSuggestion": false
                                   },
                                   "storageRoot": "storageRoot",
                                   "workDir": "workDir",

diff --git a/src/SLCore/Service/Lifecycle/Models/FeatureFlagsDto.cs b/src/SLCore/Service/Lifecycle/Models/FeatureFlagsDto.cs
@@ -28,5 +28,6 @@ public record FeatureFlagsDto(
         bool shouldManageServerSentEvents,
         bool enableDataflowBugDetection,
         bool shouldManageFullSynchronization,
-        bool enableTelemetry);
+        bool enableTelemetry,
+        bool canOpenFixSuggestion);
 }