SLVS-1406 Add binding changed trigger to ActiveSolutionBoundTracker #5642
Conversation
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
| eventCounter.SolutionBindingChangedCount.Should().Be(0); | ||
|
|
||
| eventCounter.RaisedEventNames.Should().HaveCount(2); | ||
| eventCounter.RaisedEventNames[0].Should().Be("PreSolutionBindingUpdated"); |
There was a problem hiding this comment.
Use name of instead of hardcoded string for event name.
Both in here and in the line 626
| eventCounter.SolutionBindingUpdatedCount.Should().Be(0); | ||
|
|
||
| eventCounter.RaisedEventNames.Should().HaveCount(2); | ||
| eventCounter.RaisedEventNames[0].Should().Be("PreSolutionBindingChanged"); |
There was a problem hiding this comment.
Use name of instead of hardcoded string for event name.
Maybe search and replace in the whole file?
There was a problem hiding this comment.
I didn't change these, but I can try to fix this.
| } | ||
|
|
||
| [TestMethod] | ||
| public void HandleBindingChange_NewConfiguration_EventsRaisedInCorrectOrder() |
There was a problem hiding this comment.
This test seems to be a copy-past of OnBindingStateChanged_NewConfiguration_EventsRaisedInCorrectOrder.
Can we maybe extract the whole content in a method and provide the act as a parameter to the method?
There was a problem hiding this comment.
The event-based test will be removed once we get rid of the old binding window
|
|
||
| [TestMethod] | ||
| public void HandleBindingChange_WhenClearBoundProject_NotRaised() | ||
| { |
There was a problem hiding this comment.
This test seems to be a copy-past of SolutionBindingUpdated_WhenClearBoundProject_NotRaised.
Can we maybe extract the whole content in a method and provide the act as a parameter to the method?
There was a problem hiding this comment.
The event-based test will be removed once we get rid of the old binding window
| @@ -544,6 +603,29 @@ public void SolutionBindingUpdated_WhenSetBoundProject_EventsRaisedInExpectedOrd | |||
| eventCounter.RaisedEventNames[1].Should().Be("SolutionBindingUpdated"); | |||
| } | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void HandleBindingChange_WhenSetBoundProject_EventsRaisedInExpectedOrder() | |||
There was a problem hiding this comment.
This test seems to be a copy-past of SolutionBindingUpdated_WhenSetBoundProject_EventsRaisedInExpectedOrder.
Can we maybe extract the whole content in a method and provide the act as a parameter to the method?
There was a problem hiding this comment.
The event-based test will be removed once we get rid of the old binding window
|
georgii-borovinskikh-sonarsource
merged commit ccf0822
into
feature/new-connected-mode
SLVS-1406