SLVS-1376 Binding Dialog: list connections #5649
Conversation
…etter testability
…Source/sonarlint-visualstudio into gt/list-connections-binding-dialog
terraform-techuser
changed the title
| @@ -351,4 +351,10 @@ | |||
| <data name="ValidatingOrganziationSelectionFailedText" xml:space="preserve"> | |||
| <value>The connection is not valid for the chosen organization "{0}". Make sure the entered key matches exactly your organization's key.</value> | |||
| </data> | |||
| <data name="LoadingConnectionsFailedText" xml:space="preserve"> | |||
| <value>Could not load existing connections</value> | |||
There was a problem hiding this comment.
Is it possible to show a message on the dropdown, when there are no connections?
Something like "No connections found. Please consider creating a new one!"
There was a problem hiding this comment.
The combobox control does not support this, unfortunately. But we do have a TextBlock that has a placeholder text when no selection exists. I could adapt this TextBlock and disable the combobox. What do you say?
There was a problem hiding this comment.
I also noticed that, but I didn't do it, because I was not sure if we should invest the effort.
There was a problem hiding this comment.
Yes, at the moment, it looks confusing when there is no connection because the dropdown is opening and has a large area (the height of the pop-up is too long). In the beginning, I thought that something was not working properly and the entries were not visible. If adding the text is too difficult, can we decrease the height of the pop up..
…list of connections (#5651) [SLVS-1382](https://sonarsource.atlassian.net/browse/SLVS-1382) [SLVS-1382]: https://sonarsource.atlassian.net/browse/SLVS-1382?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
|
gabriela-trutan-sonarsource
merged commit 30af3c4
into
feature/new-connected-mode
gabriela-trutan-sonarsource
deleted the
gt/list-connections-binding-dialog
branch
SLVS-1376
To test this feature in the UI, you have to adapt the DummyServerConnectionsRepository.GetAll to return some connections instead of throwing