SLVS-1399 Implement IServerConnectionRepository #5663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terraform-techuser
changed the title
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
| { | ||
| lock (LockObject) | ||
| { | ||
| try |
There was a problem hiding this comment.
I don't think try catch is needed here. Read... already does logging, mapper should not throw normally and TryWrite does not throw
There was a problem hiding this comment.
It's exactly the mapper that can throw, more exactly: GetServerConnectionsListJsonModel and, more specifically, the GetServerConnectionJsonModel
Base automatically changed from
gt/extend-file-handler
to
feature/new-connected-mode
September 3, 2024 09:27
gabriela-trutan-sonarsource
force-pushed
the
gt/implement-server-connections-repo
branch
from
97ee856 to
2b76ed8
Compare
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource
approved these changes
Sep 4, 2024
| @@ -35,7 +35,7 @@ internal class ServerConnectionsRepositoryAdapter(IServerConnectionsRepository s | |||
| { | |||
| public List<Connection> GetAllConnections() | |||
| { | |||
| var connections = serverConnectionsRepository.GetAll(); | |||
| serverConnectionsRepository.TryGetAll(out var connections); | |||
There was a problem hiding this comment.
the return value should not be ignored
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
|
gabriela-trutan-sonarsource
merged commit c36a36d
into
feature/new-connected-mode
3 checks passed
gabriela-trutan-sonarsource
deleted the
gt/implement-server-connections-repo
branch
vnaskos-sonar
pushed a commit
that referenced
this pull request
Sep 12, 2024
vnaskos-sonar
pushed a commit
that referenced
this pull request
Sep 19, 2024
gabriela-trutan-sonarsource
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1399
This PR targets this PR, because it depends on it for the implementation.
The server connections could be tested with the UI: if the file exists, the connections are shown in the manage binding dialog and manage connections dialog. Adding a connection with the UI is not implemented yet.
Example of a valid json:
{
"serverConnections": [
{
"id": "https://sonarcloud.io/organizations/myOrg",
"setting": {
"IsSmartNotificationsEnabled": false
},
"organizationKey": "mya",
"serverUri": null
}
]
}