Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVS-1379 Binding Dialog: Implement Use Shared Binding Configuration #5697

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

gabriela-trutan-sonarsource
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource commented Sep 20, 2024

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title SLVS-1379 Binding Dialog: Implement Use Shared Binding Configuration SLVS-1379 Binding Dialog: Implement Use Shared Binding Configuration Sep 20, 2024
if (!connectedModeServices.ServerConnectionsRepositoryAdapter.TryGetServerConnectionById(connectionId, out var serverConnection))
{
connectedModeServices.Logger.WriteLine(ConnectedMode.Resources.UseSharedBinding_ConnectionNotFound, connectionId);
connectedModeServices.MessageBox.Show(UiResources.NotFoundConnectionForSharedBindingMessageBoxText, UiResources.NotFoundConnectionForSharedBindingMessageBoxCaption, MessageBoxButton.OK, MessageBoxImage.Warning);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After showing this message, VS thinks that SL is stuck
image

This might be a threading issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce it on this PR...

src/ConnectedMode/UI/Resources/UiResources.resx Outdated Show resolved Hide resolved
Copy link

Copy link
Contributor

@vnaskos-sonar vnaskos-sonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vnaskos-sonar vnaskos-sonar merged commit c76da97 into feature/new-connected-mode Sep 24, 2024
3 checks passed
@vnaskos-sonar vnaskos-sonar deleted the gt/shared-binding-support branch September 24, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants