SLVS-1457 Open ManageBindingDialog from SharedBindingGoldBar #5699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce between MEF components. - The circular reference was: VsSessionHost -> SharedBindingSuggestionService -> UnintrusiveBindingController -> ActiveSolutionBoundTracker -> VsSessionHost - Fixed it by removing the SharedBindingSuggestionService from VsSessionHost and instead let it show the goldbar, whenever the active solution state changed
…om VsSessionHost, which were used only by the ConnectionController (which should be deleted once the TeamExplorer will be deleted)
hashicorp-vault-sonar-prod
bot
changed the title
…geBindingDialog once the "Bind" button in the goldbar is clicked.
vnaskos-sonar
requested changes
Sep 24, 2024
| using SonarQube.Client; | ||
|
|
||
| namespace SonarLint.VisualStudio.Integration.MefServices | ||
| { | ||
| internal interface ISharedBindingSuggestionService | ||
| public interface ISharedBindingSuggestionService : IDisposable |
There was a problem hiding this comment.
If I am not mistaken this is not necessary to be public, it can be internal
There was a problem hiding this comment.
It has to be accessible to the SonarLintIntegrationPackage, that's why the interface is public
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1457
It should have been easy: just instantiate the ManageBindingDialog in the SharedBindingSuggestionService and pass it to the goldbar. But it was a mess, because once you start adding the reference to IConnectedModeBindingServices you have a circular reference that crashes the app at runtime (the circular reference was VsSessionHost -> SharedBindingSuggestionService -> UnintrusiveBindingController -> ActiveSolutionBoundTracker -> VsSessionHost)
So I had to restructure the logic to break the circular refernce.