SLVS-1448 Prevent deleting connection when in use #5701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o associated project bindings
…calculate the number of referenced bindings by a server connection
hashicorp-vault-sonar-prod
bot
changed the title
vnaskos-sonar
approved these changes
Sep 25, 2024
src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs
Outdated
Show resolved
Hide resolved
|
gabriela-trutan-sonarsource
merged commit 3b6f543
into
feature/new-connected-mode
2 checks passed
gabriela-trutan-sonarsource
deleted the
gt/prevent-deleting-connection
branch
gabriela-trutan-sonarsource
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1448
I did not change the existing DeleteConnectionDialog, because it would have taken too much time and I would have needed to add all kinds of special logic, that later will be thrown away.
Instead, I introduced a PreventDeleteConnectionDialog, which can be completely thrown away once the unbind feature is implemented.