SLVS-1473 Refactor AliveConnectionTracker #5717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verConnectionRepository instead of ISolutionBindingRepository. The connections are saved in a dedicated repository and is no longer calculated from binding, therefore we need to listen to the repository.
hashicorp-vault-sonar-prod
bot
changed the title
|
gabriela-trutan-sonarsource
changed the base branch from
feature/hardening-8-4
to
master
gabriela-trutan-sonarsource
changed the base branch from
master
to
feature/hardening-8-4
vnaskos-sonar
pushed a commit
that referenced
this pull request
Oct 1, 2024
vnaskos-sonar
pushed a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1473
Update ActiveConnectionTracker to listen to events from ServerConnectionRepository instead of ISolutionBindingRepository.
The connections are saved in a dedicated file and are no longer calculated from binding. Therefore, we need to listen to the repository.
Update the ServerConnectionRepository to raise events when a connection is added/deleted/updated and when the credentials are changed.
This PR is only really testable in conjunction with the this PR