Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVS-1512 Improve UX #5742

Merged
merged 11 commits into from
Oct 15, 2024

Conversation

gabriela-trutan-sonarsource
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource commented Oct 14, 2024

…ation of the projectSelectionViewModel.

The ServerConnection can not change during the lifetime of the project selection dialog, therefore it is safe to store.
… filter is cleared.

It doesn't make sense when the filter is cleared to reload all the projects by asking SlCore, because the chance that the list of projects changed is low. Instead the advantage can be considerable for users that have more than 10.000 projects.
…n icon to make it more visible it is search related
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title SLVS-1512 Improve UX SLVS-1512 Improve UX Oct 14, 2024
Base automatically changed from gt/implement-fuzzy-search to feature/hardening-8-6 October 14, 2024 13:39
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource marked this pull request as ready for review October 14, 2024 13:58
Copy link
Contributor

@vnaskos-sonar vnaskos-sonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +293 to +294
[DataRow(" ")]
[DataRow("\t")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to Trim the search term and count those cases as empty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HasSearchTerm property is used to determine what text we should show when the list of projects is entered. If the user enters an empty string " " and there are no projects found for that, then we should show the message accordingly. So when " " is entered the text should say "no project was found for the entered search term" and not "No project exists"

We can trim the SearchTerm property before sending it to SlCore, but I am expecting that the search is optimized for this cases, so I don't think it is needed from our side for now.

src/ConnectedMode/UI/Resources/UiResources.resx Outdated Show resolved Hide resolved
Copy link

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource merged commit 934455b into feature/hardening-8-6 Oct 15, 2024
2 checks passed
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource deleted the gt/fuzzy-search-ux branch October 15, 2024 12:52
vnaskos-sonar pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants