-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLVS-1512 Improve UX #5742
SLVS-1512 Improve UX #5742
Conversation
…ation of the projectSelectionViewModel. The ServerConnection can not change during the lifetime of the project selection dialog, therefore it is safe to store.
…ith a progress bar.
… filter is cleared. It doesn't make sense when the filter is cleared to reload all the projects by asking SlCore, because the chance that the list of projects changed is low. Instead the advantage can be considerable for users that have more than 10.000 projects.
…n icon to make it more visible it is search related
… for each key stroke.
… many projects on the server
…cific search term
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[DataRow(" ")] | ||
[DataRow("\t")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to Trim the search term and count those cases as empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HasSearchTerm property is used to determine what text we should show when the list of projects is entered. If the user enters an empty string " " and there are no projects found for that, then we should show the message accordingly. So when " " is entered the text should say "no project was found for the entered search term" and not "No project exists"
We can trim the SearchTerm property before sending it to SlCore, but I am expecting that the search is optimized for this cases, so I don't think it is needed from our side for now.
Quality Gate passedIssues Measures |
934455b
into
feature/hardening-8-6
SLVS-1512