Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVS-1536 Add IRoslynWorkspaceWrapper & IRoslynSolutionWrapper implementation #5767

Merged
merged 4 commits into from
Oct 22, 2024
Merged

SLVS-1536 Add IRoslynWorkspaceWrapper & IRoslynSolutionWrapper implementation #5767

merged 4 commits into from
Oct 22, 2024

Conversation

georgii-borovinskikh-sonarsource
Copy link
Contributor

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource commented Oct 21, 2024 •
edited by jira bot
Loading

Base automatically changed from gb/analyzer-management to feature/dotnet-analyzer-repackaging October 21, 2024 14:21
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource marked this pull request as ready for review October 21, 2024 14:49
vnaskos-sonar
vnaskos-sonar approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@vnaskos-sonar vnaskos-sonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/Infrastructure.VS.UnitTests/Roslyn/RoslynSolutionWrapperTests.cs Outdated
}

[TestMethod]
public void AddAnalyzer_CurrentSolutionNoLongerContainsAnalyzer()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name doesn't seem correct based on what the test is doing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo with the No

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource merged commit 86e68a7 into feature/dotnet-analyzer-repackaging Oct 22, 2024
2 checks passed
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource deleted the gb/roslyn-wrappers branch October 22, 2024 11:56
georgii-borovinskikh-sonarsource added a commit that referenced this pull request Nov 5, 2024
@georgii-borovinskikh-sonarsource
SLVS-1536 Add IRoslynWorkspaceWrapper & IRoslynSolutionWrapper implem…
5be2d39 
…entation (#5767)

[SLVS-1536](https://sonarsource.atlassian.net/browse/SLVS-1536)

[SLVS-1536]:
https://sonarsource.atlassian.net/browse/SLVS-1536?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
vnaskos-sonar pushed a commit that referenced this pull request Nov 7, 2024
@georgii-borovinskikh-sonarsource @vnaskos-sonar
SLVS-1536 Add IRoslynWorkspaceWrapper & IRoslynSolutionWrapper implem…
ac08e1b 
…entation (#5767)

[SLVS-1536](https://sonarsource.atlassian.net/browse/SLVS-1536)

[SLVS-1536]:
https://sonarsource.atlassian.net/browse/SLVS-1536?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
georgii-borovinskikh-sonarsource added a commit that referenced this pull request Nov 26, 2024
@georgii-borovinskikh-sonarsource
SLVS-1536 Add IRoslynWorkspaceWrapper & IRoslynSolutionWrapper implem…
bca0a57 
…entation (#5767)

[SLVS-1536](https://sonarsource.atlassian.net/browse/SLVS-1536)

[SLVS-1536]:
https://sonarsource.atlassian.net/browse/SLVS-1536?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
vnaskos-sonar pushed a commit that referenced this pull request Nov 26, 2024
@georgii-borovinskikh-sonarsource @vnaskos-sonar
SLVS-1536 Add IRoslynWorkspaceWrapper & IRoslynSolutionWrapper implem…
e7b9387 
…entation (#5767)

[SLVS-1536](https://sonarsource.atlassian.net/browse/SLVS-1536)

[SLVS-1536]:
https://sonarsource.atlassian.net/browse/SLVS-1536?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnaskos-sonar vnaskos-sonar vnaskos-sonar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgii-borovinskikh-sonarsource @vnaskos-sonar