SLVS-1551 Remove the AnalyzerUpdatedForConnection #5775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from IConnectedModeRoslynAnalyzerProvider The event is not needed, because there is no SlCore listener that informs about the fact that the enterprise analyzer has to be used. Instead it's a service, which SL can use to make a decision.
hashicorp-vault-sonar-prod
bot
changed the title
|
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
|
If we get rid of this event, there's a race condition between the analyzer choice+registration and the config scope declaration+end of sync (or whenever the data is available for SLCore to tell us which analyzer should be used) |
|
Closed the PR, because, as discussed with Georgii, we still want the event |
gabriela-trutan-sonarsource
deleted the
gt/cm-roslyn-analyzer-provider-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1551