Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVS-1561 Close notifications when solution is closed #5781

Merged
merged 3 commits into from
Oct 28, 2024
Merged

SLVS-1561 Close notifications when solution is closed #5781

merged 3 commits into from
Oct 28, 2024

Conversation

vnaskos-sonar
Copy link
Contributor

@vnaskos-sonar vnaskos-sonar commented Oct 28, 2024 •
edited
Loading

SLVS-1561

Part of SLVS-1183

Expectations:

  1. When closing a solution notifications should be closed

    Except for the ones that are session-scoped (NodeJS version, Sloop restart)

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Close notifications when solution is closed SLVS-1561 Close notifications when solution is closed Oct 28, 2024
@vnaskos-sonar vnaskos-sonar mentioned this pull request Oct 28, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vnaskos-sonar vnaskos-sonar merged commit d03becf into feature/hardening-8-7 Oct 28, 2024
3 checks passed
@vnaskos-sonar vnaskos-sonar deleted the vn/slvs-1183-close-on-solution-close branch October 28, 2024 15:28
georgii-borovinskikh-sonarsource pushed a commit that referenced this pull request Nov 5, 2024
@vnaskos-sonar @georgii-borovinskikh-sonarsource
SLVS-1561 Close notifications when solution is closed (#5781)
39a6438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnaskos-sonar @georgii-borovinskikh-sonarsource