SLVS-1563 Raise CurrentConfigurationScopeChanged when configuration scope changed #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
Base automatically changed from
gt/config-scope-tracker-tests
to
feature/dotnet-analyzer-repackaging
October 29, 2024 10:28
gabriela-trutan-sonarsource
force-pushed
the
gt/add-config-scope-updated-event
branch
from
ee2ef1e to
01b675d
Compare
There was a problem hiding this comment.
Looks good, except that raising the event under lock can be problematic. I think we need to move it outsider the synchronization blocks. But if we do that, we shouldn't have the configscope value in the event parameter to prevent race conditions (callers will need to call IActiveConfigScopeTracker.Current to get the up to date value)
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
|
georgii-borovinskikh-sonarsource
approved these changes
Oct 30, 2024
gabriela-trutan-sonarsource
merged commit 9c8de05
into
feature/dotnet-analyzer-repackaging
4 checks passed
gabriela-trutan-sonarsource
deleted the
gt/add-config-scope-updated-event
branch
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Nov 5, 2024
vnaskos-sonar
pushed a commit
that referenced
this pull request
Nov 7, 2024
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Nov 8, 2024
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Nov 8, 2024
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Nov 11, 2024
vnaskos-sonar
pushed a commit
that referenced
this pull request
Nov 18, 2024
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1563
This is a draft, because it targets the PR, which is needed for the tests. It can still be reviewed.