Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVS-1565 User should be able to update the credentials #5785

Merged
merged 3 commits into from
Oct 29, 2024
Merged

SLVS-1565 User should be able to update the credentials #5785

merged 3 commits into from
Oct 29, 2024

Conversation

vnaskos-sonar
Copy link
Contributor

@vnaskos-sonar vnaskos-sonar commented Oct 29, 2024 •
edited
Loading

SLVS-1565

Part of SLVS-1385

Expectations:

  1. You should be able to see the edit connection button on the connections list
  2. You should be able to update the credentials of any connection

    You can test that after updating the credentials when having an unbound project, the "Select Project" loads correctly

Note: Re-triggering the connection is not part of this task

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title User should be able to update the credentials SLVS-1565 User should be able to update the credentials Oct 29, 2024
gabriela-trutan-sonarsource
gabriela-trutan-sonarsource approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have some feedback regarding the tests

src/ConnectedMode.UnitTests/ServerConnectionsRepositoryAdapterTests.cs Outdated Show resolved Hide resolved
src/ConnectedMode.UnitTests/ServerConnectionsRepositoryAdapterTests.cs Show resolved Hide resolved
src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs Outdated Show resolved Hide resolved
src/ConnectedMode.UnitTests/UI/ManageConnections/ManageConnectionsViewModelTest.cs Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vnaskos-sonar vnaskos-sonar merged commit 3bc0fff into feature/edit-credentials Oct 29, 2024
2 checks passed
@vnaskos-sonar vnaskos-sonar deleted the vn/edit-credentials branch October 29, 2024 17:24
vnaskos-sonar added a commit that referenced this pull request Nov 4, 2024
@vnaskos-sonar
SLVS-1565 User should be able to update the credentials (#5785)
8023ba6
vnaskos-sonar added a commit that referenced this pull request Nov 6, 2024
@vnaskos-sonar
SLVS-1565 User should be able to update the credentials (#5785)
4094c7b
vnaskos-sonar added a commit that referenced this pull request Nov 7, 2024
@vnaskos-sonar
SLVS-1565 User should be able to update the credentials (#5785)
d6e618d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource gabriela-trutan-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnaskos-sonar @gabriela-trutan-sonarsource