SLVS-1597 Store SLCore issue id in AnalysisIssue #5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
gabriela-trutan-sonarsource
requested review from
georgii-borovinskikh-sonarsource and
vnaskos-sonar
and removed request for
georgii-borovinskikh-sonarsource
Base automatically changed from
gb/taint-dto-conversion
to
feature/severity-modes
November 12, 2024 09:00
Id should be nullable, because issues that do not come form SlCore do not have an id (e.g. CFamily, roslyn issues) Move the id to the base interface, because it is required by the task https://sonarsource.atlassian.net/browse/SLVS-1598
|
gabriela-trutan-sonarsource
merged commit 6baf1e0
into
feature/severity-modes
4 checks passed
vnaskos-sonar
pushed a commit
that referenced
this pull request
Nov 18, 2024
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1597
This PR targets the PR that adds the TaintVulnerabilityDto to IAnalysisIssue conversion, which is needed to be able to store the IDs of the taints as well (when they are converted to AnalysisIssues)
Although the PR is a draft, it can be reviewed. Once the target PR is merged into the feature branch, I will convert it to a normal PR