SLVS-1598 Use getEffectiveIssueDetails for issues with SLCore id instead of getEffectiveRuleDetails #5830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rableIssue from the corresponding error row from VS error list
…n issue from VS Error list.
hashicorp-vault-sonar-prod
bot
changed the title
gabriela-trutan-sonarsource
changed the title
gabriela-trutan-sonarsource
changed the title
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource
requested changes
Nov 13, 2024
| @@ -36,8 +34,7 @@ public record EffectiveRuleDetailsDto( | |||
| VulnerabilityProbability? vulnerabilityProbability, | |||
| [property: JsonConverter(typeof(EitherJsonConverter<RuleMonolithicDescriptionDto, RuleSplitDescriptionDto>))] | |||
| Either<RuleMonolithicDescriptionDto, RuleSplitDescriptionDto> description, | |||
| List<EffectiveRuleParamDto> @params); | |||
| [JsonProperty("params")] List<EffectiveRuleParamDto> parameters) : IRuleDetails; | |||
There was a problem hiding this comment.
not sure if this looks better
There was a problem hiding this comment.
It is needed for the implemenation of the IRuleDetails.
The EffectiveIssueDetailsDto and EffectiveRuleDetailsDto are very similar, which is why this interface was introduced.
This also prevents code duplication of converting 99% similar Dtos to RuleInfo in the SLCoreRuleMetaDataProvider
Additionally, it is the same in the EffectiveIssueDetailsDto. I just made them consistent now
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource
approved these changes
Nov 14, 2024
|
gabriela-trutan-sonarsource
merged commit 1fad501
into
feature/severity-modes
2 checks passed
gabriela-trutan-sonarsource
deleted the
gt/use-get-effective-issue-details
branch
vnaskos-sonar
pushed a commit
that referenced
this pull request
Nov 18, 2024
…ead of getEffectiveRuleDetails (#5830)
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Nov 20, 2024
…ead of getEffectiveRuleDetails (#5830)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1598