SLVS-1678 Use unique generated compilation database names #5875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
georgii-borovinskikh-sonarsource
marked this pull request as ready for review
| act.Should().Throw<ArgumentNullException>().Which.ParamName.Should().Be("filePath"); | ||
| } | ||
|
|
||
| [TestInitialize] |
There was a problem hiding this comment.
TestInitialize should be at the top of the class
gabriela-trutan-sonarsource
approved these changes
Dec 9, 2024
src/Integration.Vsix/CFamily/VcxProject/TemporaryCompilationDatabaseHandle.cs
Show resolved
Hide resolved
|
|
||
| private static IAnalysisStatusNotifierFactory CreateDefaultAnalysisStatusNotifier(out IAnalysisStatusNotifier notifier) | ||
| private void SetUpDefaultAnalysisStatusNotifier(out IAnalysisStatusNotifier notifier) |
There was a problem hiding this comment.
I would remove the out parameter and make the IAnalysisStatusNotifier a field.
|
|
||
| notifier.Received().AnalysisFailed(exception); | ||
| } | ||
|
|
||
| private static ISLCoreServiceProvider CreatServiceProvider(out IAnalysisSLCoreService analysisService, bool result = true) | ||
| private void SetUpServiceProvider(out IAnalysisSLCoreService analysisService, bool result = true) |
There was a problem hiding this comment.
I would remove the out parameter and make the IAnalysisSLCoreService a field.
|
georgii-borovinskikh-sonarsource
merged commit 8863499
into
feature/cfamily-migration
3 checks passed
georgii-borovinskikh-sonarsource
deleted the
gb/unique-compilation-database
branch
georgii-borovinskikh-sonarsource
added a commit
that referenced
this pull request
Dec 9, 2024
georgii-borovinskikh-sonarsource
added a commit
that referenced
this pull request
Dec 24, 2024
georgii-borovinskikh-sonarsource
added a commit
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1678