Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVS-1377 Implement unbind in Binding Dialog #5880

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

gabriela-trutan-sonarsource
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource commented Dec 9, 2024

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title SLVS-1377 [Visual Studio] Binding Dialog: Unbind SLVS-1377 [Visual Studio] Binding Dialog: Unbind Dec 9, 2024
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource changed the title SLVS-1377 [Visual Studio] Binding Dialog: Unbind SLVS-1377 Implement unbind in Binding Dialog Dec 9, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but the controller/asbt interaction potentially needs to be changed

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource merged commit b5acb8b into feature/unbind Dec 11, 2024
3 checks passed
@gabriela-trutan-sonarsource gabriela-trutan-sonarsource deleted the gt/unbind-btn branch December 11, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants