MCP-248 Create Advanced Analysis Tool #175

eray-felek-sonarsource · 2026-01-27T15:20:07Z

No description provided.

src/main/java/org/sonarsource/sonarqube/mcp/configuration/McpServerLaunchConfiguration.java

nquinquenel · 2026-01-27T21:24:46Z

src/main/java/org/sonarsource/sonarqube/mcp/SonarQubeMcpServer.java

+   * Loads analysis tools based on configuration.
+   * When advanced analysis is enabled on SonarCloud, registers the advanced remote analysis tool.
+   * Otherwise, registers local analysis tools (IDE bridge tools or analyze_code_snippet).
   */
-  private void loadBackendDependentTools() {
+  private void loadAnalysisTools() {


I'd keep the previous name loadBackendDependentTools, it's important because otherwise we would simply add these tools where others are declared.

My only concern is that this tool does not depend on backend and it would be very hard for someone to understand why we have this tool under a function named this way. I think a better option would having the check higher level and calling either loadBackendDependentTools or loadAdvancedAnalysis(making it a separate function) WDYT?

nquinquenel · 2026-01-27T21:28:12Z

src/test/java/org/sonarsource/sonarqube/mcp/AdvancedAnalysisEnablementTest.java

+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class AdvancedAnalysisEnablementTest {


I don't think we need this test class

It was for coverage

If you want to keep it I'd move it somewhere else, it's currently at the root of the test folder

README.md

sonarqubecloud · 2026-01-28T09:15:04Z

SonarQube reviewer guide

Important

We are currently testing different models for AI Summary.
Please give us your feedback by filling this form.

Model A:

Summary: Add advanced analysis mode for SonarCloud with feature flag to replace local analysis tools

Review Focus: The conditional tool loading logic in SonarQubeMcpServer.initializeBasicServicesAndTools() that switches between standard and advanced analysis modes based on environment flag and SonarCloud detection. The new tool currently only returns a placeholder "Hello, World" response.

Start review at: src/main/java/org/sonarsource/sonarqube/mcp/SonarQubeMcpServer.java. This file contains the core branching logic that determines which analysis tools are loaded and includes the important fallback behavior for non-SonarCloud environments.

Model B:

Summary: Add support for advanced code analysis mode on SonarCloud, controlled by the SONARQUBE_ADVANCED_ANALYSIS_ENABLED environment variable. When enabled on SonarCloud, the new run_advanced_code_analysis tool replaces local analysis tools.

Review Focus:

The conditional logic in SonarQubeMcpServer.initializeBasicServicesAndTools() that switches between advanced and standard analysis paths—ensure the SonarCloud detection and fallback behavior are correct.
The RunAdvancedCodeAnalysisTool currently returns a placeholder "Hello, World" response and will need actual implementation.
Verify that disabling local analysis tools when advanced mode is active doesn't break dependent functionality.

Start review at: src/main/java/org/sonarsource/sonarqube/mcp/SonarQubeMcpServer.java. This is the entry point where the feature is gated and tool loading strategy is determined. Understanding the initialization flow and conditional tool registration is critical to validating the overall design.

See all code changes, issues, and quality metrics in one place.

Quality Gate passed

Issues
0 New issues
1 Accepted issue
0 Dependency risks

Measures
0 Security Hotspots
96.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

This PR introduces an advanced analysis tool for SonarCloud environments, allowing users to opt into a new analysis mode that replaces local analysis tools with a remote advanced analysis capability.

Changes:

Added RunAdvancedCodeAnalysisTool - a new tool that provides advanced code analysis functionality (currently returns "Hello, World" as a placeholder implementation)
Added configuration support via SONARQUBE_ADVANCED_ANALYSIS_ENABLED environment variable/system property
Implemented conditional tool loading logic that enables advanced analysis tools on SonarCloud while falling back to standard analysis on SonarQube Server

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/main/java/org/sonarsource/sonarqube/mcp/tools/analysis/RunAdvancedCodeAnalysisTool.java`	New tool implementation with placeholder "Hello, World" response
`src/main/java/org/sonarsource/sonarqube/mcp/configuration/McpServerLaunchConfiguration.java`	Added configuration field and getter for advanced analysis enablement flag
`src/main/java/org/sonarsource/sonarqube/mcp/SonarQubeMcpServer.java`	Modified tool loading logic to conditionally load advanced or standard analysis tools based on configuration
`src/test/java/org/sonarsource/sonarqube/mcp/tools/analysis/RunAdvancedCodeAnalysisToolTests.java`	Added unit tests for the new tool's basic properties and placeholder behavior
`src/test/java/org/sonarsource/sonarqube/mcp/configuration/McpServerLaunchConfigurationTest.java`	Added tests for parsing and handling the new configuration flag
`src/test/java/org/sonarsource/sonarqube/mcp/AdvancedAnalysisEnablementTest.java`	Added integration tests verifying tool registration behavior and fallback logic
`README.md`	Updated documentation to describe the new advanced analysis feature and configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-28T18:27:40Z

src/main/java/org/sonarsource/sonarqube/mcp/SonarQubeMcpServer.java

+      }
+      loadBackendDependentTools();
+    }
+


The loadProxiedServerTools() call has been removed from the initialization flow, which means proxied MCP servers and their tools will never be loaded. This breaks functionality that depends on proxied tools. The call to loadProxiedServerTools() should be restored after the conditional tool loading logic.

Suggested change

loadProxiedServerTools();

nquinquenel · 2026-01-28T18:30:47Z

src/main/java/org/sonarsource/sonarqube/mcp/SonarQubeMcpServer.java

+  private void loadAdvancedAnalysisTools() {
+    supportedTools.add(new RunAdvancedCodeAnalysisTool());
+  }


I'm not sure we need a method for a single line addition to a list

nquinquenel · 2026-01-28T18:33:35Z

README.md

 | Toolset            | Key                 | Description                                                          |
 |--------------------|---------------------|----------------------------------------------------------------------|
-| **Analysis**       | `analysis`          | Code analysis tools (analyze code snippets and files)                |
+| **Analysis**       | `analysis`          | Code analysis tools (local analysis and advanced analysis)           |


I think we should mention that it's remote

nquinquenel · 2026-01-28T18:33:50Z

src/main/java/org/sonarsource/sonarqube/mcp/tools/analysis/RunAdvancedCodeAnalysisTool.java

+    super(SchemaToolBuilder.forOutput(RunAdvancedCodeAnalysisToolResponse.class)
+      .setName(TOOL_NAME)
+      .setTitle("Advanced Code Analysis")
+      .setDescription("Run advanced code analysis remotely using SonarCloud advanced analysis.")


Suggested change

.setDescription("Run advanced code analysis remotely using SonarCloud advanced analysis.")

.setDescription("Run advanced code analysis remotely using SonarQube Cloud advanced analysis.")

eray-felek-sonarsource force-pushed the feature/ef/MCP-248-create-a3s-tool branch 2 times, most recently from 301878e to 8a6f907 Compare January 27, 2026 15:50

eray-felek-sonarsource marked this pull request as ready for review January 27, 2026 16:08

eray-felek-sonarsource requested a review from nquinquenel January 27, 2026 16:08

eray-felek-sonarsource changed the base branch from master to feature/ef/MCP-245-integrate-with-a3s January 27, 2026 16:19

nquinquenel reviewed Jan 27, 2026

View reviewed changes

eray-felek-sonarsource force-pushed the feature/ef/MCP-248-create-a3s-tool branch from 8a6f907 to 2e99400 Compare January 28, 2026 08:52

MCP-248 Create Advanced Analysis Tool

2108f70

eray-felek-sonarsource force-pushed the feature/ef/MCP-248-create-a3s-tool branch from 2e99400 to 2108f70 Compare January 28, 2026 09:05

eray-felek-sonarsource requested a review from nquinquenel January 28, 2026 09:21

nquinquenel requested a review from Copilot January 28, 2026 18:27

Copilot AI reviewed Jan 28, 2026

View reviewed changes

nquinquenel reviewed Jan 28, 2026

View reviewed changes

SonarSource deleted a comment from Copilot AI Jan 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MCP-248 Create Advanced Analysis Tool #175

MCP-248 Create Advanced Analysis Tool #175

Uh oh!

eray-felek-sonarsource commented Jan 27, 2026

Uh oh!

Uh oh!

nquinquenel Jan 27, 2026

Uh oh!

eray-felek-sonarsource Jan 28, 2026 •

edited

Loading

Uh oh!

nquinquenel Jan 27, 2026

Uh oh!

eray-felek-sonarsource Jan 28, 2026

Uh oh!

nquinquenel Jan 28, 2026

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

nquinquenel Jan 28, 2026

Uh oh!

nquinquenel Jan 28, 2026

Uh oh!

nquinquenel Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		import static org.assertj.core.api.Assertions.assertThat;

		class AdvancedAnalysisEnablementTest {

	.setDescription("Run advanced code analysis remotely using SonarCloud advanced analysis.")
	.setDescription("Run advanced code analysis remotely using SonarQube Cloud advanced analysis.")

MCP-248 Create Advanced Analysis Tool #175

Are you sure you want to change the base?

MCP-248 Create Advanced Analysis Tool #175

Uh oh!

Conversation

eray-felek-sonarsource commented Jan 27, 2026

Uh oh!

Uh oh!

nquinquenel Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

eray-felek-sonarsource Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nquinquenel Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

eray-felek-sonarsource Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

nquinquenel Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 28, 2026

SonarQube reviewer guide

Model A:

Model B:

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

nquinquenel Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

nquinquenel Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

nquinquenel Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eray-felek-sonarsource Jan 28, 2026 •

edited

Loading