Added changes for default hit actions for tc backend #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Sosutha
commented
Apr 2, 2024
Sosutha
commented
- Updated tc_may_override hint to be used with default_hit actions
Sosutha
force-pushed
the
p4tc_default_hit
branch
from
647fcc2 to
a3a93a2
Compare
Sosutha
force-pushed
the
p4tc_default_hit
branch
4 times, most recently
from
a258e1a to
eb38f27
Compare
syogender
reviewed
May 16, 2024
syogender
approved these changes
May 16, 2024
komaljai
approved these changes
May 16, 2024
vbnogueira
reviewed
May 20, 2024
| action next_hop(PortId_t vport) { | ||
| send_to_port(vport); | ||
| } | ||
| action default_route_drop() { |
There was a problem hiding this comment.
Small nit, can you rename to dflt_route_drop?
The action name is too big for the template as is
There was a problem hiding this comment.
@vbnogueira Please confirm
Looks good to me
* Updated tc_may_override hint to be used with default_hit actions * Added testcases for tc_may_override hint with default_hit action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.