505-atualizar-dados-cadastrais-no-perfil-do-usuario #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sers e UserRegisterRequest para incluir os campos: cidade,estado e discord
rigonlucas
requested changes
May 13, 2024
|
@lthurler alguns pontos a serem considerados:
|
…ps://github.com/lthurler/labs-api into Atomics-505-atualizar-perfil-de-usuario-backend
rigonlucas
requested changes
May 13, 2024
lthurler
changed the title
rigonlucas
reviewed
May 22, 2024
rigonlucas
reviewed
May 22, 2024
lthurler
changed the title
lthurler
changed the title
|
ok feito |
docker-compose1.yml
Outdated
There was a problem hiding this comment.
Esse arquivo deveria está nos commits?
There was a problem hiding this comment.
Quando der um tempo vamos realizar algumas melhorias nele :-)
rigonlucas
reviewed
May 27, 2024
storage/swagger/http.json
Outdated
| @@ -0,0 +1 @@ | |||
| {"openapi":"3.0.0","paths":{"\/index":{"get":{"tags":["\/Index"],"summary":"GET example","operationId":"c7a3e07c42ef883719b986d0d3195666","responses":{"200":{"description":"Description of the returned value","content":{"application\/json":{"schema":[],"example":"{\"code\":200, \"data\":[]}"}}}}}}}} | |||
rigonlucas
approved these changes
Jun 11, 2024
Guilherme-Silva0
approved these changes
Jun 11, 2024
figmateus
approved these changes
Jun 12, 2024
| $table->string('permission')->nullable(); | ||
| $table->string('cidade', 32); | ||
| $table->string('estado', 20); | ||
| $table->string('discord',30)->nullable(); |
There was a problem hiding this comment.
se os campos discord e linkedin sao obrigatorios porque eles podem ser nulos ?
There was a problem hiding this comment.
Boa pergunta.
Essa base da dados já existe, entao usuários anteriores a está feature devem ficar como null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alteração no UserController ,LoginRepository , UserRegisterRequest para incluir os campos: cidade,estado e discord. Criado uma migrate alter table para incluir os campos no banco de dados.
Tarefa em: SouJunior/products#505