DIA-4456 integrate core /meta-data
#835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nevazhnovu
approved these changes
Sep 26, 2024
cmplibrary/src/androidTest/java/com/sourcepoint/cmplibrary/campaign/CampaignManagerImplTest.kt
Show resolved
Hide resolved
| if (newRate != dataStorage.ccpaSampleRate) { | ||
| dataStorage.ccpaSampleRate = newRate | ||
| ccpa.sampleRate.let { newRate -> | ||
| if (newRate.toDouble() != dataStorage.ccpaSampleRate) { |
There was a problem hiding this comment.
Once again, I am not sure how kotlin handles things, but a straight comparison of two values with floating point might be error-prone.
Based on my C# experience, I would drop this banger:
if( newRate.toDouble() - dataStorage.ccpaSampleRate > Math.Epsilon )
Where Math.Epsilon is a really tiny value (0.000001 or similar).
Might be a false alarm, though :)
There was a problem hiding this comment.
That's a very good point. I thought about it while coding, but forgot to address it.
cmplibrary/src/main/java/com/sourcepoint/cmplibrary/campaign/CampaignManager.kt
Outdated
Show resolved
Hide resolved
cmplibrary/src/main/java/com/sourcepoint/cmplibrary/campaign/CampaignManager.kt
Outdated
Show resolved
Hide resolved
cmplibrary/src/main/java/com/sourcepoint/cmplibrary/data/network/util/ResponseManager.kt
Outdated
Show resolved
Hide resolved
cmplibrary/src/main/java/com/sourcepoint/cmplibrary/model/exposed/SpConfig.kt
Outdated
Show resolved
Hide resolved
cmplibrary/src/release/java/com/sourcepoint/cmplibrary/creation/ComponentFactory.kt
Show resolved
Hide resolved
...ry/src/test/java/com/sourcepoint/cmplibrary/data/network/model/optimized/MetaDataRespTest.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mobile-coreas dependencySourcepointClientintoNetworkClient/meta-dataimplementation/meta-datacode